mgr/cephadm: extend extra_container_args to other service types#45136
Merged
adk3798 merged 1 commit intoceph:masterfrom Feb 28, 2022
Merged
mgr/cephadm: extend extra_container_args to other service types#45136adk3798 merged 1 commit intoceph:masterfrom
adk3798 merged 1 commit intoceph:masterfrom
Conversation
mgfritch
approved these changes
Feb 24, 2022
Contributor
|
jenkins retest this please |
Otherwise, without this change, this can only be used for mgr, mon and crash (daemons without their own service spec class) Fixes: https://tracker.ceph.com/issues/54390 Signed-off-by: Adam King <adking@redhat.com>
Contributor
Author
|
Most Failures tracked by: and a couple upgrade test failures. One where it mysteriously failed redeploying a grafana daemon (the last daemon redeployed during upgrade) and one where it looped on the mgr needing to upgrade itself. Errors don't seem related to the PRs in the run. |
Contributor
Author
14 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, without this change, this can only be used for mgr,
mon and crash (daemons without their own service spec class)
Fixes: https://tracker.ceph.com/issues/54390
Signed-off-by: Adam King adking@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox