Skip to content

[WIP] mgr/orch: add exception type to the OrchResult#44995

Closed
mgfritch wants to merge 1 commit intoceph:mainfrom
mgfritch:orch-pickle-except
Closed

[WIP] mgr/orch: add exception type to the OrchResult#44995
mgfritch wants to merge 1 commit intoceph:mainfrom
mgfritch:orch-pickle-except

Conversation

@mgfritch
Copy link
Contributor

@mgfritch mgfritch commented Feb 11, 2022

per 146fd47,
failures to pickle degrade into a generic exception

attempt to re-raise using the originating exception type after
a pickle failure has occured

Fixes: https://tracker.ceph.com/issues/54264
Signed-off-by: Michael Fritch mfritch@suse.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

per 146fd47,
failures to pickle degrade into a generic exception

attempt to re-raise using the originating exception type after
a pickle failure has occured

Fixes: https://tracker.ceph.com/issues/54264
Signed-off-by: Michael Fritch <mfritch@suse.com>
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Apr 16, 2022
@djgalloway djgalloway changed the base branch from master to main May 25, 2022 20:03
@mgfritch mgfritch closed this Jul 28, 2022
@mgfritch mgfritch deleted the orch-pickle-except branch July 28, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant