Skip to content

qa/dashboard: ensure node 16 is installed#44578

Merged
epuertat merged 1 commit intoceph:masterfrom
rhcs-dashboard:fix-53843-master
Jan 18, 2022
Merged

qa/dashboard: ensure node 16 is installed#44578
epuertat merged 1 commit intoceph:masterfrom
rhcs-dashboard:fix-53843-master

Conversation

@epuertat
Copy link
Member

@epuertat epuertat commented Jan 13, 2022 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/53843
Signed-off-by: Ernesto Puerta epuertat@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@epuertat epuertat requested a review from a team as a code owner January 13, 2022 16:33
@epuertat epuertat requested review from a team, nizamial09 and pereman2 and removed request for a team January 13, 2022 16:33
@ljflores
Copy link
Member

ljflores commented Jan 13, 2022

jenkins test dashboard

@ljflores
Copy link
Member

ljflores commented Jan 13, 2022

The affected test is rados/dashboard/{0-single-container-host debug/mgr mon_election/connectivity random-objectstore$/{bluestore-comp-zlib} tasks/e2e}; perhaps this PR should be run through Teuthology to make sure the tests are green?

@djgalloway
Copy link
Contributor

djgalloway commented Jan 14, 2022

Can this safely be installed with/over another version of NodeJS?

Why are we installing a deprecated version?

@epuertat
Copy link
Member Author

epuertat commented Jan 14, 2022 •
edited
Loading

Can this safely be installed with/over another version of NodeJS?

Why are we installing a deprecated version?

@djgalloway I simply downloaded the nodejs 12 script since it's the minimum required by Angular 12 and the one we've been testing in our Jenkinks jobs, but you're right: given 12 is almost EoL, we should update to 16 (the next LTS). Both are supported by CentOS 8 and Ubuntu 20.04. I'll fix it.

epuertat
epuertat commented Jan 14, 2022
View reviewed changes
qa/workunits/cephadm/test_dashboard_e2e.sh
$SUDO apt-get install curl gpg
KEYRING=/usr/share/keyrings/nodesource.gpg
curl -fsSL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | gpg --dearmor | $SUDO tee "$KEYRING" >/dev/null
DISTRO="$(source /etc/lsb-release; echo $DISTRIB_CODENAME)"
Copy link
Member Author

@epuertat epuertat Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a trick not to have to install lsb-core (which triggers the install of another 165 packages).

@epuertat epuertat changed the title qa/dashboard: ensure node 12 is installed qa/dashboard: ensure node 16 is installed Jan 14, 2022
@epuertat epuertat requested a review from alfonsomthd January 14, 2022 17:14
@epuertat
Copy link
Member Author

epuertat commented Jan 14, 2022

@djgalloway updated, can you please review?

@sebastian-philipp
Copy link
Contributor

sebastian-philipp commented Jan 17, 2022

while you're here: you want to move qa/workunits/cephadm/test_dashboard_e2e.sh to qa/workunits/dashboard/test_dashboard_e2e.sh ?

@nizamial09 nizamial09 added the needs-quincy-backport backport required for quincy label Jan 18, 2022
@epuertat
Copy link
Member Author

epuertat commented Jan 18, 2022

while you're here: you want to move qa/workunits/cephadm/test_dashboard_e2e.sh to qa/workunits/dashboard/test_dashboard_e2e.sh ?

@sebastian-philipp since @yuriw already validated this PR, I'll keep it this way. We can change it afterwards.

@epuertat epuertat merged commit 86590ea into ceph:master Jan 18, 2022
@epuertat epuertat deleted the fix-53843-master branch January 18, 2022 19:23
@ljflores
Copy link
Member

ljflores commented Jan 18, 2022

@epuertat posting this for your reference. The dashboard tests that were failing have passed!

http://pulpito.front.sepia.ceph.com/yuriw-2022-01-15_05:47:18-rados-wip-yuri8-testing-2022-01-14-1551-distro-default-smithi/
http://pulpito.front.sepia.ceph.com/yuriw-2022-01-17_17:14:22-rados-wip-yuri8-testing-2022-01-14-1551-distro-default-smithi/

Failures, unrelated:
https://tracker.ceph.com/issues/45721
https://tracker.ceph.com/issues/50280
https://tracker.ceph.com/issues/53827
https://tracker.ceph.com/issues/51076
https://tracker.ceph.com/issues/53807
https://tracker.ceph.com/issues/53842

Details:
Bug_#45721: CommandFailedError: Command failed (workunit test rados/test_python.sh) FAIL: test_rados.TestWatchNotify.test
Bug_#50280: cephadm: RuntimeError: uid/gid not found - Ceph
Bug_#53827: cephadm exited with error code when creating osd. - Ceph - Orchestrator
Bug_#51076: "wait_for_recovery: failed before timeout expired" during thrashosd test with EC backend.
Bug_#53807: Dead jobs in rados/cephadm/smoke-roleless{...} - Ceph - Orchestrator
Bug_#53842: cephadm/mds_upgrade_sequence: KeyError: 'en***'

@nizamial09 nizamial09 mentioned this pull request Jan 19, 2022
Merged
@epuertat
Copy link
Member Author

epuertat commented Jan 19, 2022

Thanks a lot for the (detailed) good news, @ljflores ! 🥳

@sebastian-philipp sebastian-philipp mentioned this pull request Jan 25, 2022
Merged
@epuertat epuertat mentioned this pull request Jan 28, 2022
Merged
14 tasks
@epuertat epuertat removed the needs-quincy-backport backport required for quincy label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@djgalloway djgalloway djgalloway approved these changes

@pereman2 pereman2 pereman2 approved these changes

@nizamial09 nizamial09 nizamial09 approved these changes

Assignees

No one assigned

Labels

cephadm dashboard tests wip-yuri8-testing

Projects

Ceph-Dashboard
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@epuertat @ljflores @djgalloway @sebastian-philipp @alfonsomthd @pereman2 @nizamial09 @yuriw