pacific: mgr/autoscaler: Introduce noautoscale flag#44540
Merged
yuriw merged 3 commits intoceph:pacificfrom Jan 26, 2022
Merged
pacific: mgr/autoscaler: Introduce noautoscale flag#44540yuriw merged 3 commits intoceph:pacificfrom
yuriw merged 3 commits intoceph:pacificfrom
Conversation
1e8a2c4 to
29db24b
Compare
Member
Author
|
jenkins test make check |
Member
Author
2022-01-12T16:14:07.118 INFO:tasks.workunit.client.0.smithi124.stderr:+ unset CEPH_CLI_TEST_DUP_COMMAND
2022-01-12T16:14:07.119 INFO:tasks.workunit.client.0.smithi124.stderr:++ ceph osd pool ls
2022-01-12T16:14:07.119 INFO:tasks.workunit.client.0.smithi124.stderr:++ wc -l
2022-01-12T16:14:07.394 INFO:tasks.workunit.client.0.smithi124.stderr:+ NUM_POOLS=1
2022-01-12T16:14:07.394 INFO:tasks.workunit.client.0.smithi124.stderr:+ '[' 1 -gt 0 ']'
2022-01-12T16:14:07.395 INFO:tasks.workunit.client.0.smithi124.stdout:test requires no preexisting pools
2022-01-12T16:14:07.396 DEBUG:teuthology.orchestra.run:got remote process result: 1
2022-01-12T16:14:07.396 INFO:tasks.workunit.client.0.smithi124.stderr:+ echo 'test requires no preexisting pools'
2022-01-12T16:14:07.397 INFO:tasks.workunit.client.0.smithi124.stderr:+ exit 1
2022-01-12T16:14:07.397 INFO:tasks.workunit:Stopping ['mon/test_noautoscale_flag.sh'] on client.0...test created device_health_metrics, need to modify the test to not create it. |
29db24b to
73bc2a4
Compare
Member
Author
|
1/1 Test passed the change in test-noautoscale-flag.yaml worked. |
Member
Author
|
Still need to be tested against the rados suite to make sure it's clean |
neha-ojha
approved these changes
Jan 20, 2022
Comment on lines
35
to
+42
| >=16.2.7 | ||
| -------- | ||
|
|
||
| * MGR: The pg_autoscaler can now be turned `on` and `off` globally | ||
| with the `noautoscale` flag. By default this flag is unset and | ||
| the default pg_autoscale mode remains the same. | ||
| For more details, see: | ||
|
|
||
| https://docs.ceph.com/en/latest/rados/operations/placement-groups/ |
Member
There was a problem hiding this comment.
nit: should be under 16.2.8 now
`noautoscale` flag is a feature where the user can choose to flip the switch between turning autoscale `on` and `off` for all pools with a single command. `osd pool set noautoscale` will turn all autoscale mode`off` for all pools. `osd pool unset noautoscale` will turn all autoscale mode `on` for all pools. Signed-off-by: Kamoltat <ksirivad@redhat.com> (cherry picked from commit be17f04) Conflicts: src/pybind/mgr/pg_autoscaler/module.py - trivial fix
set and unset the noautoscale flag, evaluate if the results are what we expected. As well as, evaluate if the flag is correct when we create new pools. Signed-off-by: Kamoltat <ksirivad@redhat.com> (cherry picked from commit bb42c71) Conflicts: test-noautoscale-flag.yaml - modified pre-mgr-command to not create device health monitor
Updated the docs in https://docs.ceph.com/en/latest/rados/operations/placement-groups/ and updated the release notes to reflect noautoscale flag. Signed-off-by: Kamoltat <ksirivad@redhat.com> (cherry picked from commit 9baed03) Conflicts: PendingReleaseNotes - trivial fix
73bc2a4 to
b5fb850
Compare
vumrao
approved these changes
Jan 26, 2022
Member
|
jenkins test api |
1 similar comment
Member
|
jenkins test api |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noautoscaleflag is a feature where theuser can choose to flip the switch between
turning autoscale
onandofffor allpools with a single command.
osd pool set noautoscalewill turn allautoscale mode
offfor all pools.osd pool unset noautoscalewill turn allautoscale mode
onfor all pools.Fixes: https://tracker.ceph.com/issues/53769
Backporting the relevant commits from master PR:
#43716
Signed-off-by: Kamoltat ksirivad@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox