RGW Zipper - don't load stats for every bucket load#44538
Merged
dang merged 1 commit intoceph:masterfrom Jan 13, 2022
Merged
Conversation
cbodley
approved these changes
Jan 11, 2022
| virtual RGWAccessControlPolicy& get_acl(void) override { return acls; } | ||
| virtual int set_acl(const DoutPrefixProvider* dpp, RGWAccessControlPolicy& acl, optional_yield y) override; | ||
| virtual int load_bucket(const DoutPrefixProvider* dpp, optional_yield y) override; | ||
| virtual int load_bucket(const DoutPrefixProvider* dpp, optional_yield y, bool get_stats = false) override; |
Contributor
There was a problem hiding this comment.
nit: avoid default arguments in virtual interfaces
Member
|
Fixed the performance issue observed during OSD cache aging binning testing. Thanks @dang! |
markhpc
approved these changes
Jan 11, 2022
3 tasks
Contributor
Author
|
jenkins test api |
This was a side-effect of consolidating the Zipper API, and resulted in a large performance hit. Stats are only needed if they are requested, so don't load them every time. Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
f5cb997 to
661cda6
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a side-effect of consolidating the Zipper API, and resulted in
a large performance hit. Stats are only needed if they are requested,
so don't load them every time.
Signed-off-by: Daniel Gryniewicz dang@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox