mgr/cephadm: still check agent deps if it is marked down#44489
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Jan 18, 2022
Merged
mgr/cephadm: still check agent deps if it is marked down#44489sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp merged 1 commit intoceph:masterfrom
Conversation
Contributor
|
Could you add a more meaningful description to your commit message? |
sebastian-philipp
suggested changes
Jan 7, 2022
Contributor
sebastian-philipp
left a comment
There was a problem hiding this comment.
commit message is empty
Right now if an agent is down, the way _check_agent works if will return without ever going on to check the deps or scheduled actions for that agent. This causes a few issues. For one, if an agent is marked down and then a mgr failover happens, even if reconfiguring the agent would put it in a working state (e.g. changing the target ip if the active mgr has moved) we never try it because _check_agent just returns as soon as it sees the agent is down. Additionally, if someone purposely tried to schedule a redeploy of a down agent for whatever reason, we would never make good on this action. This change allows us to still carry out the normal checks/ scheduled actions even on down agents Fixes: https://tracker.ceph.com/issues/53723 Signed-off-by: Adam King <adking@redhat.com>
b64704c to
09a593c
Compare
Member
|
jenkins test api |
Member
|
jenkins test dashboard cephadm |
sebastian-philipp
approved these changes
Jan 17, 2022
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/53723
Signed-off-by: Adam King adking@redhat.com
Additionally, it's important to make sure the agent actually successfully received the new
config before updating the deps so that has been moved to the thread that sends the config to the agent
Most of the line changes here are just un-indenting a bunch of code that was formerly part of an else block.
Thinking this will fix the teuthology issues in the linked tracker. Will have to make sure that
cephadm/workunits/{agent/on mon_election/connectivity task/test_nfs}andcephadm/workunits/{agent/on mon_election/connectivity task/test_orch_cli}don't fail with wait until healthy timeouts on whatever qa runs this is put through.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox