Skip to content

mgr/cephadm: nfs migration: avoid port conflicts#44482

Merged
yuriw merged 1 commit intoceph:masterfrom
sebastian-philipp:nfs-upgrade-port-conflict
Jan 11, 2022
Merged

mgr/cephadm: nfs migration: avoid port conflicts#44482
yuriw merged 1 commit intoceph:masterfrom
sebastian-philipp:nfs-upgrade-port-conflict

Conversation

@sebastian-philipp
Copy link
Contributor

@sebastian-philipp sebastian-philipp commented Jan 6, 2022 •
edited by adk3798
Loading

The nfs upgrade renames the nfs spec from nfs.ganesha-{service_id}
to nfs.{service_id}. Previously we used the orphan-daemon check
to remove the old nfs.ganesha-{service_id} daemons. This does not work
as sometimes serve() tries to deploy the new daemons before cleaning up the
old daemons. This results in a port conflict breaking the upgrade.

Fixes: https://tracker.ceph.com/issues/53424
Signed-off-by: Sebastian Wagner sewagner@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@sebastian-philipp
mgr/cephadm: nfs migration: avoid port conflicts
d2cbf91 
The nfs upgrade renames the nfs spec from `nfs.ganesha-{service_id}`
to `nfs.{service_id}`. Previously we used the orphan-daemon check
to remove the old `nfs.ganesha-{service_id}` daemons. This does not work
as sometimes serve() tries to deploy the new daemons before cleaning up the
old daemons. This results in a port conflict breaking the upgrade.

Fixes: https://tracker.ceph.com/issues/53424
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
@sebastian-philipp sebastian-philipp requested a review from a team as a code owner January 6, 2022 11:36
@sseshasa
Copy link
Contributor

sseshasa commented Jan 10, 2022

Teuthology Run Report:
http://pulpito.front.sepia.ceph.com/yuriw-2022-01-08_17:57:43-rados-wip-yuri8-testing-2022-01-07-1541-distro-default-smithi/

Unrelated Failures:

  1. http://pulpito.front.sepia.ceph.com/yuriw-2022-01-08_17:57:43-rados-wip-yuri8-testing-2022-01-07-1541-distro-default-smithi/6603232

    Failure Reason:
    Command failed (workunit test rados/test.sh) on smithi038 with status 124: 'mkdir -p -- /home/ubuntu/cephtest/mnt.0/client.0/tmp && cd -- /home/ubuntu/cephtest/mnt.0/client.0/tmp && CEPH_CLI_TEST_DUP_COMMAND=1 CEPH_REF=ec609d2f45e32caa04ced0b8259e177d254d49fa TESTDIR="/home/ubuntu/cephtest" CEPH_ARGS="--cluster ceph" CEPH_ID="0" PATH=$PATH:/usr/sbin CEPH_BASE=/home/ubuntu/cephtest/clone.client.0 CEPH_ROOT=/home/ubuntu/cephtest/clone.client.0 CEPH_MNT=/home/ubuntu/cephtest/mnt.0 ALLOW_TIMEOUTS=1 adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 6h /home/ubuntu/cephtest/clone.client.0/qa/workunits/rados/test.sh'

    Existing tracker: https://tracker.ceph.com/issues/52124

  2. http://pulpito.front.sepia.ceph.com/yuriw-2022-01-08_17:57:43-rados-wip-yuri8-testing-2022-01-07-1541-distro-default-smithi/6603250
    http://pulpito.front.sepia.ceph.com/yuriw-2022-01-08_17:57:43-rados-wip-yuri8-testing-2022-01-07-1541-distro-default-smithi/6603470

    Failure reason:
    Command failed on smithi100 with status 1: 'sudo /home/ubuntu/cephtest/cephadm --image quay.ceph.io/ceph-ci/ceph:ec609d2f45e32caa04ced0b8259e177d254d49fa shell -c /etc/ceph/ceph.conf -k /etc/ceph/ceph.client.admin.keyring --fsid 786ae1de-70c1-11ec-8c32-001a4aab830c -- ceph mon dump -f json'

    Existing tracker: https://tracker.ceph.com/issues/49287

  3. http://pulpito.front.sepia.ceph.com/yuriw-2022-01-08_17:57:43-rados-wip-yuri8-testing-2022-01-07-1541-distro-default-smithi/6603271

    Failure reason:
    Test failure: test_module_commands (tasks.mgr.test_module_selftest.TestModuleSelftest)

    Existing tracker: https://tracker.ceph.com/issues/52652

The dead jobs numbering 9 are unrelated as well.

@yuriw
Copy link
Contributor

yuriw commented Jan 10, 2022

jenkins test this please

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jan 10, 2022

jenkins test docs

@yuriw
Copy link
Contributor

yuriw commented Jan 10, 2022

jenkins test api

1 similar comment
@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jan 11, 2022

jenkins test api

@yuriw
Copy link
Contributor

yuriw commented Jan 11, 2022

@sebastian-philipp @adk3798 this is ready for merge. Failing tests
Please merge at will

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jan 11, 2022

jenkins test docs

@yuriw yuriw merged commit ba92927 into ceph:master Jan 11, 2022
@sebastian-philipp sebastian-philipp mentioned this pull request Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adk3798 adk3798 adk3798 approved these changes

@liewegas liewegas Awaiting requested review from liewegas

Assignees

No one assigned

Labels

cephadm needs-qa pybind wip-yuri8-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebastian-philipp @sseshasa @yuriw @adk3798