mgr/dashboard: fix orchestrator/02-hosts-inventory.e2e failure#44388
mgr/dashboard: fix orchestrator/02-hosts-inventory.e2e failure#44388alfonsomthd merged 1 commit intoceph:masterfrom
Conversation
|
jenkins test dashboard |
|
jenkins test dashboard cephadm |
|
Should this be backported to pacific? |
epuertat
left a comment
There was a problem hiding this comment.
Looks good! Small suggestion: instead of decrementing the number of the remaining files, can't we let them as they are? I mean, just skipping the 02, and going to 03, 04, etc.? It's just to minimize the impact of changes: just for not running a single file we are touching 6.
@alfonsomthd : Yes. |
Yup, I'll do that but it felt odd missing a number between 01 and 03 |
92b1572 to
8327a0b
Compare
No need: it's actually more important to use this numbering for univocally identifying tests by ID (or number) than keeping the sequence gapless (although we're actually using the numbering for another purpose here: setting the tests execution order). We barely use IDs for tests, but in other environments is pretty common to assign IDs to tests, so that you can see in which branches/releases that specific test unit is failing (Cypress allows you to do that, but in Jenkins/JUnit we're not leveraging that). |
I removed the `02-hosts-inventory.e2e` file because it is a duplicate test of one of the test in the `01-hosts.e2e` file and fixed the error from that file. Also, in the inventory Identify test, we test for an element to be not visible. According to the latest cypress docs, this should be not.exist instead of not.visible since the cd-modal will not even be present in the DOM Fixes: https://tracker.ceph.com/issues/53499 Signed-off-by: Nizamudeen A <nia@redhat.com>
8327a0b to
7b9fb25
Compare
|
Jenkins test make check |
|
Jenkins test dashboard |
|
Jenkins test api |
|
@nizamial09 Can you add a comment with the results of the QA run? |
QA run: |
|
jenkins test windows |
|
Looks like the teuthology is green 🥳 |
I removed the
02-hosts-inventory.e2efile because it is a duplicatetest of one of the test in the
01-hosts.e2efile and fixed the errorfrom that file.
Also, in the inventory Identify test, we test for an element to be not
visible. According to the latest cypress docs, this should be
not.existinstead of
not.visiblesince the cd-modal will not even be present inthe DOM
Fixes: https://tracker.ceph.com/issues/53499
Signed-off-by: Nizamudeen A nia@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox