mgr/cephadm: Do not propogate access logs from cherrypy#44017
Merged
liewegas merged 1 commit intoceph:masterfrom Dec 3, 2021
Merged
mgr/cephadm: Do not propogate access logs from cherrypy#44017liewegas merged 1 commit intoceph:masterfrom
liewegas merged 1 commit intoceph:masterfrom
Conversation
sebastian-philipp
approved these changes
Nov 30, 2021
Contributor
|
(unrelated) We now have an ugly bug preventing the nfs upgrade from completing: https://tracker.ceph.com/issues/53424 |
Contributor
|
jenkins test make check |
Contributor
|
cephadm/agent.py:41:1: E305 expected 2 blank lines after class or function definition, found 1 |
The only messages we're really interested in are errors that would come from the error logs. The acces logs only provide messages like - [18/Nov/2021:23:55:32] "POST /data HTTP/1.1" 200 - "" "Python-urllib/3.8" which we don't want spammed to the log, especially since they are logged at INFO level Signed-off-by: Adam King <adking@redhat.com>
78b0ccc to
5449b30
Compare
Contributor
Author
|
jenkins test api |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only messages we're really interested in are errors that
would come from the error logs. The access logs only provide
messages like
10.221.1.44 - - [18/Nov/2021:23:55:32] "POST /data HTTP/1.1" 200 - "" "Python-urllib/3.8"
which we don't want spammed to the log, especially since they are
logged at INFO level
Signed-off-by: Adam King adking@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox