osd: make osd_fast_shutdown_notify_mon option true by default#44016
Closed
satoru-takeuchi wants to merge 1 commit intoceph:mainfrom
Closed
osd: make osd_fast_shutdown_notify_mon option true by default#44016satoru-takeuchi wants to merge 1 commit intoceph:mainfrom
satoru-takeuchi wants to merge 1 commit intoceph:mainfrom
Conversation
3 tasks
neha-ojha
reviewed
Nov 19, 2021
Member
|
@liewegas discovered https://tracker.ceph.com/issues/53327, so we should change the default after this bug is fixed |
osd_fast_shutdown_notify_mon option is false by default. So users suffer from error log flood, slow ops, and the long I/O timeouts on voluntary OS shutdown before they are aware of the existence of this option. Let's make this option true by default. Fixes: https://tracker.ceph.com/issues/53328 Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
7302e8d to
bf4d358
Compare
14 tasks
Contributor
Author
|
This fix is in #44807. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
osd_fast_shutdown_notify_mon option is false by default. So users suffer
from error log flood, slow ops, and the long I/O timeouts on voluntary OS
shutdown before they are aware of the existence of this option. Let's
make this option true by default.
Fixes: https://tracker.ceph.com/issues/53328
Signed-off-by: Satoru Takeuchi satoru.takeuchi@gmail.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox