mgr/dashboard: fix flaky inventory e2e test#43992
Merged
epuertat merged 1 commit intoceph:masterfrom Nov 22, 2021
Merged
Conversation
avanthakkar
approved these changes
Nov 18, 2021
pereman2
approved these changes
Nov 18, 2021
Contributor
|
jenkins test make check |
Contributor
|
jenkins test dashboard cephadm |
1 similar comment
Member
Author
|
jenkins test dashboard cephadm |
aaSharma14
approved these changes
Nov 18, 2021
Member
Author
|
jenkins test dashboard cephadm |
1 similar comment
Member
Author
|
jenkins test dashboard cephadm |
Waadkh7
approved these changes
Nov 18, 2021
Member
Author
|
jenkins test dashboard cephadm |
epuertat
approved these changes
Nov 19, 2021
Member
|
@nizamial09 a tracker is needed before merging this |
When `inventory.getTableCount('total').should('be.eq', totalDiskCount);`
this line is executed the table was not loaded properly and hence the
getTableCount returns 0 on the first try but on second try it passes
since the table is loaded. But in orch e2es the retries are set to 0. I
am not sure if it makes sense to set it to 1. Anyway I am adapting the
test a bit to expect the count to be equal to totalDiskCount so that the
test will wait a bit.
Fixes: https://tracker.ceph.com/issues/53353
Signed-off-by: Nizamudeen A <nia@redhat.com>
6cfc6c2 to
cdce5f7
Compare
Member
Author
@epuertat done! |
Member
|
jenkins test api |
Member
|
API test error unknown. |
Member
|
jenkins test dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
inventory.getTableCount('total').should('be.eq', totalDiskCount);this line is executed the table was not loaded properly and hence the
getTableCountreturns 0 on the first try but on second try it passessince the table is loaded. But in orch e2es the retries are set to 0. I
am not sure if it makes sense to set it to 1. Anyway I am adapting the
test a bit to expect the count to be equal to
totalDiskCountso that thetest will wait a bit.
Fixes: https://tracker.ceph.com/issues/53353
Signed-off-by: Nizamudeen A nia@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox