os/bluestore: Disable compaction then no-column-b is storing allocations to bluefs file#43645
Merged
liewegas merged 1 commit intoceph:masterfrom Oct 28, 2021
Merged
Conversation
…ons to bluefs file During BlueStore umount we store current allocation state to disk, in form of bluefs file. If RocksDB was performing compaction during capture of allocator state, it could cause corruption. Solution is to delete db (stop RocksDB) before state capture. Fixes: https://tracker.ceph.com/issues/52399 Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Contributor
Author
|
https://gist.github.com/aclamk/cadc3561da8771901534aae4f6d20bde describes how compaction leads to HybridAllocator assert. |
3 tasks
Member
|
Let's run it through a broader rados run as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During BlueStore umount we store current allocation state to disk, in form of bluefs file.
If RocksDB was performing compaction during capture of allocator state, it could cause corruption.
Solution is to delete db (stop RocksDB) before state capture.
Fixes: https://tracker.ceph.com/issues/52399
Signed-off-by: Adam Kupczyk akupczyk@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox