Skip to content

rgw: add rgw_curl_tcp_keepalive option for http client requests#43609

Closed
cbodley wants to merge 1 commit intoceph:mainfrom
cbodley:wip-48402
Closed

rgw: add rgw_curl_tcp_keepalive option for http client requests#43609
cbodley wants to merge 1 commit intoceph:mainfrom
cbodley:wip-48402

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented Oct 20, 2021

this can be useful to prevent long-lived connections from being dropped due to inactivity

Fixes: https://tracker.ceph.com/issues/48402

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@cbodley
rgw: add rgw_curl_tcp_keepalive option for http client requests
72a3794 
this can be useful to prevent long-lived connections from being dropped
due to inactivity

Fixes: https://tracker.ceph.com/issues/48402

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley cbodley added the rgw label Oct 20, 2021
@mkogan1
Copy link
Contributor

mkogan1 commented Nov 14, 2021

jenkins test make check arm64

@mkogan1
Copy link
Contributor

mkogan1 commented Nov 14, 2021

jenkins test api

mkogan1
mkogan1 approved these changes Nov 14, 2021
View reviewed changes
Copy link
Contributor

@mkogan1 mkogan1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just adding note that in the future if necessary we may add the keep-alive tuning options:
CURLOPT_TCP_KEEPIDLE - Sets the delay that the operating system will wait while the connection is idle before sending keepalive probes
CURLOPT_TCP_KEEPINTVL - Sets the interval that the operating system will wait between sending keepalive probes

@djgalloway djgalloway changed the base branch from master to main June 28, 2022 22:42
@github-actions
Copy link

github-actions bot commented Aug 27, 2022

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Aug 27, 2022
@cbodley cbodley mentioned this pull request Nov 23, 2022
Merged
@cbodley
Copy link
Contributor Author

cbodley commented Nov 23, 2022

included in #48898

@cbodley cbodley closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkogan1 mkogan1 mkogan1 approved these changes

@mdw-at-linuxbox mdw-at-linuxbox Awaiting requested review from mdw-at-linuxbox

@ofriedma ofriedma Awaiting requested review from ofriedma

Assignees

No one assigned

Labels

common pending-discussion rgw stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbodley @mkogan1