test: increase retry duration when calculating manifest ref. count#43493
test: increase retry duration when calculating manifest ref. count#43493yuriw merged 1 commit intoceph:masterfrom
Conversation
neha-ojha
left a comment
There was a problem hiding this comment.
@myoungwon thanks for looking into this, could you please add the Fixes: https://tracker.ceph.com/issues/52872 line in the commit message
In situation where the object is degraded and delayed, retry time can expire before the object is recovered ---it takes almost 6 minutes to be recovered according to the log. Fixes: https://tracker.ceph.com/issues/52872 Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
|
@neha-ojha Done. |
|
@athanatos @neha-ojha Please take a look. |
| } | ||
| break; | ||
| } | ||
| ASSERT_TRUE(tries < 30); |
There was a problem hiding this comment.
Can this actually fail? Why does tries need to be outside of the loop?
There was a problem hiding this comment.
I added this line for the purpose of debugging. The two issues above generated error logs like ASSERT_TRUE(src_refcount == expected_refcount);. So, It is hard to catch the cause because I need to read all logs generated from the cluster. This line might help us to recognize the error caused by the retry.
neha-ojha
left a comment
There was a problem hiding this comment.
I am fine with going ahead with this version before we find a more reliable fix as discussed in https://tracker.ceph.com/issues/53219
In situation where the object is degraded and delayed,
retry time can expire before the object is recovered
---it takes almost 6 minutes to be recovered according to
the log.
fixes: https://tracker.ceph.com/issues/52872,
https://tracker.ceph.com/issues/53219
Signed-off-by: Myoungwon Oh myoungwon.oh@samsung.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox