Skip to content

qa/tasks/rook: test reapplication of drive groups stored in mgr#43139

Merged
josephsawaya merged 1 commit intoceph:masterfrom
josephsawaya:rook-orch-qa
Dec 17, 2021
Merged

qa/tasks/rook: test reapplication of drive groups stored in mgr#43139
josephsawaya merged 1 commit intoceph:masterfrom
josephsawaya:rook-orch-qa

Conversation

@josephsawaya
Copy link

@josephsawaya josephsawaya commented Sep 10, 2021 •
edited
Loading

This commit adds testing for the drive_group_loop in the Rook orchestrator
that reapplies drive groups that were applied previously.

This test removes an OSD, zaps the underlying device then waits for the OSD
to be re-created by the drive_group_loop.

Signed-off-by: Joseph Sawaya jsawaya@redhat.com

Depends on #43138

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

jeffvance
jeffvance reviewed Sep 13, 2021
View reviewed changes
jeffvance
jeffvance reviewed Sep 13, 2021
View reviewed changes
@jmolmo jmolmo mentioned this pull request Sep 14, 2021
Merged
3 tasks
@josephsawaya josephsawaya force-pushed the rook-orch-qa branch 8 times, most recently from 2a6fc1d to 9bb2396 Compare September 21, 2021 13:40
@github-actions
Copy link

github-actions bot commented Sep 29, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@josephsawaya josephsawaya requested a review from a team as a code owner September 29, 2021 20:17
@github-actions
Copy link

github-actions bot commented Oct 14, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@josephsawaya
Copy link
Author

josephsawaya commented Nov 1, 2021

jenkins test make check

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@github-actions
Copy link

github-actions bot commented Nov 11, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@josephsawaya
Copy link
Author

josephsawaya commented Nov 15, 2021

jenkins test make check

@liewegas
Copy link
Member

liewegas commented Nov 15, 2021 

[root@rook-ceph-tools-744c55f865-9brwh /]# ceph orch osd rm 0 --force
Error cleaning environment after removing OSDs from Ceph cluster CRD: (403)
Reason: Forbidden
HTTP response headers: HTTPHeaderDict({'Audit-Id': '20cad418-a263-4309-9313-ebb7ac722d54', 'Cache-Control': 'no-cache, private', 'Content-Type': 'application/json', 'X-Content-Type-Options': 'nosniff', 'X-Kubernetes-Pf-Flowschema-Uid': '1374b1c1-b92f-403d-b423-53c7829d5151', 'X-Kubernetes-Pf-Prioritylevel-Uid': '7f1ccd3c-4a50-4ac5-a295-b46226ab8f1e', 'Date': 'Mon, 15 Nov 2021 20:34:44 GMT', 'Content-Length': '389'})
HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"deployments.apps \"rook-ceph-osd-0\" is forbidden: User \"system:serviceaccount:rook-ceph:rook-ceph-mgr\" cannot patch resource \"deployments/scale\" in API group \"apps\" in the namespace \"rook-ceph\"","reason":"Forbidden","details":{"name":"rook-ceph-osd-0","group":"apps","kind":"deployments"},"code":403}

@liewegas
Copy link
Member

liewegas commented Nov 15, 2021 

status:
  message: No recycler plugin found for the volume!
  phase: Failed

@josephsawaya josephsawaya force-pushed the rook-orch-qa branch 2 times, most recently from 1f7577e to 66ec71e Compare December 2, 2021 15:35
@josephsawaya
Copy link
Author

josephsawaya commented Dec 2, 2021

jenkins test make check

@josephsawaya josephsawaya mentioned this pull request Dec 9, 2021
Closed
14 tasks
@josephsawaya
Copy link
Author

josephsawaya commented Dec 14, 2021

https://pulpito.ceph.com/jsawaya-2021-12-14_15:44:05-orch:rook-wip-joseph-testing-distro-basic-smithi/

sebastian-philipp
sebastian-philipp reviewed Dec 16, 2021
View reviewed changes
@sebastian-philipp
Copy link
Contributor

sebastian-philipp commented Dec 16, 2021

could you please add Fixes: https://tracker.ceph.com/issues/53501 to the commit message?

qa/tasks/rook: test reapplication of drive groups stored in mgr
280d735 
This commit adds testing for the drive_group_loop in the Rook orchestrator
that reapplies drive groups that were applied previously.

This test removes an OSD, zaps the underlying device then waits for the OSD
to be re-created by the drive_group_loop.

This commit also updates the rook test suite to test v1.7.2 instead of 1.7.0
since `orch device zap` is only supported from v1.7.2 onwards.

Fixes: https://tracker.ceph.com/issues/53501

Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
@josephsawaya josephsawaya force-pushed the rook-orch-qa branch 2 times, most recently from 0d5dbc1 to 280d735 Compare December 16, 2021 23:31
@josephsawaya
Copy link
Author

josephsawaya commented Dec 17, 2021

https://pulpito.ceph.com/jsawaya-2021-12-17_16:59:06-orch:rook-wip-joseph-testing-distro-basic-smithi/

@josephsawaya josephsawaya merged commit 8742173 into ceph:master Dec 17, 2021
@ljflores
Copy link
Member

ljflores commented Apr 1, 2022

@josephsawaya this is still happening in pacific. I think this needs PR needs a backport?

@josephsawaya
Copy link
Author

josephsawaya commented Apr 1, 2022 •
edited
Loading

@josephsawaya this is still happening in pacific. I think this needs PR needs a backport?

I'm actually working on a PR to remove the orchestrator commands from the Rook task since the orchestrator is not being maintained at the moment, will mention you in that. So some of the contents of this PR will go missing in master, so the new PR would have to be backported probably.

@ljflores
Copy link
Member

ljflores commented Apr 1, 2022

Thanks @josephsawaya!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jeffvance jeffvance jeffvance left review comments

@sebastian-philipp sebastian-philipp sebastian-philipp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

orchestrator pybind rook tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@josephsawaya @liewegas @sebastian-philipp @ljflores @jeffvance