Skip to content

rgw/multisite: remove per-shard sync status object after incremental sync finishes#42999

Closed
cbodley wants to merge 8 commits intoceph:wip-rgw-multisite-reshardfrom
cbodley:wip-rgw-multisite-reshard-rm-shard-status
Closed

rgw/multisite: remove per-shard sync status object after incremental sync finishes#42999
cbodley wants to merge 8 commits intoceph:wip-rgw-multisite-reshardfrom
cbodley:wip-rgw-multisite-reshard-rm-shard-status

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented Aug 31, 2021

updated version of #42459

  • moved the deletion code into the same if block as the call to RGWBucketShardIsDoneCR
  • switched from the IoCtx overload of RGWRadosRemoveOidCR to the rados service one

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

Copy link
Contributor

@adamemerson adamemerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me.

Shilpa Jagannath and others added 7 commits September 13, 2021 12:28
Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
As specified in rgw_bucket_index_marker_info, unless we're doing the
compatibility check, in which case we look at generation 0.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
The logic for getting it was moved to its caller.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Also remove code for negative num_shards case as that's no longer
relevant.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@adamemerson adamemerson self-assigned this Sep 13, 2021
Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley cbodley force-pushed the wip-rgw-multisite-reshard-rm-shard-status branch from 631ba21 to e9111fe Compare September 15, 2021 17:22
@adamemerson adamemerson force-pushed the wip-rgw-multisite-reshard branch from f665f7b to e14b20a Compare September 16, 2021 22:10
@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@cbodley
Copy link
Contributor Author

cbodley commented Sep 20, 2021

rebased and merged

@cbodley cbodley closed this Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants