pacific: cls/cmpomap: empty values are 0 in U64 comparisons#42908
Merged
yuriw merged 1 commit intoceph:pacificfrom Aug 25, 2021
Merged
pacific: cls/cmpomap: empty values are 0 in U64 comparisons#42908yuriw merged 1 commit intoceph:pacificfrom
yuriw merged 1 commit intoceph:pacificfrom
Conversation
previously, when trying to use cmpomap interfaces on an omap key with an empty value, U64 comparisons would fail to decode with -EIO. so cmp_set_vals() and cmp_rm_keys() are unable to update or remove such keys for backward-compatibility with rgw's data sync error repo, where the keys used to have empty values, enable these comparisons by treating an empty value as 0 Fixes: https://tracker.ceph.com/issues/52128 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 2333959)
cbodley
approved these changes
Aug 24, 2021
Merged
2 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/52330
backport of #42740
parent tracker: https://tracker.ceph.com/issues/52128
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh