rgw: fix bucket index list test error#42836
Conversation
bd6c2eb to
468ce77
Compare
src/cls/rgw/cls_rgw.cc
Outdated
| } | ||
|
|
||
| static std::string quote_escape(const std::string& s) { | ||
| return '"' + escape_str(s) + '"'; |
There was a problem hiding this comment.
perhaps its being fussy, but perhaps pre-allocate or reserve escape_str?
There was a problem hiding this comment.
Not sure if the change is what you had in mind. Please take a gander.
97f6d98 to
0e5da92
Compare
0e5da92 to
d4ed44c
Compare
Fix bugs surrounding calculation of number of entries returned and whether the end of a listing range has been reached. Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
Adding more level 20 logging for bucket index listing. Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
Make sure marker is cleared. Put end-of-list check inside the conditional with the rest of the test. Add some additional testing. Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
d4ed44c to
1bf0581
Compare
|
https://pulpito.ceph.com/cbodley-2021-09-02_14:03:39-rgw-wip-cbodley-testing-distro-basic-smithi/ seeing a lot of new failures there |
|
Teuthology results: rgw/verify: https://pulpito.ceph.com/ivancich-2021-09-03_00:17:55-rgw-wip-fix-bi-test-error-distro-basic-smithi/ I do not believe there are any regressions. These tests were run with --suite-branch set to the branch, so the new tests were used. @cbodley Is it possible that the failures you saw were due to another PR on your branch or the present state of master? |
|
thanks @ivancich! |
Fix bug surrounding calculation of number of entries returned. Add additional level 20 logging.
In test, make sure marker is cleared. Put end-of-list check inside the conditional with the rest of the test. End use of uninitialized variable.
Signed-off-by: J. Eric Ivancich ivancich@redhat.com
Fixes: https://tracker.ceph.com/issues/52315