Skip to content

pybind/mgr: Fix IPv6 url generation#42793

Merged
alfonsomthd merged 5 commits intoceph:masterfrom
sebastian-philipp:dashboard-fix-standby-redirect
Aug 19, 2021
Merged

pybind/mgr: Fix IPv6 url generation#42793
alfonsomthd merged 5 commits intoceph:masterfrom
sebastian-philipp:dashboard-fix-standby-redirect

Conversation

@sebastian-philipp
Copy link
Contributor

@sebastian-philipp sebastian-philipp commented Aug 16, 2021

Fixes: https://tracker.ceph.com/issues/52117
Signed-off-by: Sebastian Wagner sewagner@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@sebastian-philipp sebastian-philipp requested a review from a team as a code owner August 16, 2021 12:15
@sebastian-philipp sebastian-philipp requested review from Waadkh7, aaryanporwal and cypherean and removed request for a team August 16, 2021 12:15
@sebastian-philipp sebastian-philipp mentioned this pull request Aug 16, 2021
Merged
1 task
@alfonsomthd alfonsomthd changed the title mgr/dashboard: Fix redirect to active MGR mgr/dashboard: Fix redirect to active MGR Aug 16, 2021
avanthakkar
avanthakkar requested changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left some minor changes. Thanks @sebastian-philipp

@nizamial09
Copy link
Member

nizamial09 commented Aug 16, 2021

jenkins test dashboard

@sebastian-philipp sebastian-philipp force-pushed the dashboard-fix-standby-redirect branch from e5eaa85 to b035691 Compare August 17, 2021 10:48
@sebastian-philipp sebastian-philipp requested a review from a team as a code owner August 17, 2021 10:48
@sebastian-philipp sebastian-philipp changed the title mgr/dashboard: Fix redirect to active MGR pybind/mgr: Fix IPv6 url generation Aug 17, 2021
@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Aug 18, 2021 

lint run-test-pre: PYTHONHASHSEED='782397422'
lint run-test: commands[0] | flake8
./rest_client.py:331:23: W291 trailing whitespace
./rest_client.py:332:28: W291 trailing whitespace
./rest_client.py:333:28: W291 trailing whitespace

@sebastian-philipp
pybind/mgr: move build_url from dashboard to mgr_util
29883d6 
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
@sebastian-philipp
mgr/dashboard: Fix redirect to active MGR
e367796 
Fixes: https://tracker.ceph.com/issues/52117
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
@sebastian-philipp
mgr/prometheus: Fix url generation for IPv6 hosts
0b8701b 
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
@sebastian-philipp
mgr/restful: Fix url generation for IPv6 hosts
9809159 
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
@sebastian-philipp
mgr/cephadm: fix generation of wrong IPv6 urls
3d96f79 
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
@sebastian-philipp sebastian-philipp force-pushed the dashboard-fix-standby-redirect branch from b035691 to 3d96f79 Compare August 18, 2021 10:09
neha-ojha
neha-ojha approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@neha-ojha neha-ojha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

p-se
p-se approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@p-se p-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alfonsomthd alfonsomthd merged commit 9788d20 into ceph:master Aug 19, 2021
@tchaikov
Copy link
Contributor

tchaikov commented Aug 19, 2021

@alfonsomthd in future, could you please add a "Reviewed-by" line in the commit message of the merge commit when merging a PR?

@alfonsomthd
Copy link
Contributor

alfonsomthd commented Aug 19, 2021

@alfonsomthd in future, could you please add a "Reviewed-by" line in the commit message of the merge commit when merging a PR?

Of course, sorry about that. I completely forgot about it.

@sebastian-philipp sebastian-philipp mentioned this pull request Aug 23, 2021
Merged
3 tasks
This was referenced Aug 31, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-se p-se p-se approved these changes

@neha-ojha neha-ojha neha-ojha approved these changes

@avanthakkar avanthakkar avanthakkar approved these changes

@aaryanporwal aaryanporwal Awaiting requested review from aaryanporwal

@Waadkh7 Waadkh7 Awaiting requested review from Waadkh7

@cypherean cypherean Awaiting requested review from cypherean

Assignees

No one assigned

Labels

cephadm dashboard mgr needs-qa pybind

Projects

Ceph-Dashboard
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sebastian-philipp @nizamial09 @tchaikov @alfonsomthd @p-se @neha-ojha @avanthakkar