qa/standalone: fixing the timings when waiting for deep-scrub to start#42410
Merged
neha-ojha merged 1 commit intoceph:masterfrom Jul 21, 2021
Merged
qa/standalone: fixing the timings when waiting for deep-scrub to start#42410neha-ojha merged 1 commit intoceph:masterfrom
neha-ojha merged 1 commit intoceph:masterfrom
Conversation
initiate_and_fetch_state() initiates a scrub, then polls the published PG state looking for 'scrubbing'. Calling flush_pg_stats() as part of the polling process might cause the scrub and the following recovery to be missed altogether. Note: this polling mechanism is definitely not robust. Will be redesigned in the future. Fixes: https://tracker.ceph.com/issues/51581 Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Contributor
Author
neha-ojha
approved these changes
Jul 20, 2021
Member
neha-ojha
left a comment
There was a problem hiding this comment.
This is fine for now, let's try to make these tests more deterministic as a part of the broader effort to make the scrub standalone tests to work with mclock.
Member
|
https://pulpito.ceph.com/nojha-2021-07-20_16:29:12-rados:standalone-wip-ronenf-standalone-repair-distro-basic-smithi/ - Passes 10 runs of the scrub standalone tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initiate_and_fetch_state() initiates a scrub, then polls the published
PG state looking for 'scrubbing'. Calling flush_pg_stats() as part of
the polling process might cause the scrub and the following recovery to
be missed altogether.
Note: this polling mechanism is definitely not robust. Will be
redesigned in the future.
Fixes: https://tracker.ceph.com/issues/51581
Signed-off-by: Ronen Friedman rfriedma@redhat.com