qa: add a method to get keyring for a client_id#42335
qa: add a method to get keyring for a client_id#42335rishabh-d-dave merged 1 commit intoceph:mainfrom
Conversation
c0c3be6 to
5c2ed61
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
5c2ed61 to
f5a9efb
Compare
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
f5a9efb to
2668263
Compare
nmshelke
left a comment
There was a problem hiding this comment.
Are you only adding method (without actual usage) ?
2668263 to
6359358
Compare
|
@rishabh-d-dave mentioned that this is required for "fs authorize" pr - #41779 Better to include these changes in that pr. |
6359358 to
ee91410
Compare
|
For easy of review, testing and merge this commit is being moved again. |
|
jenkins test make check |
|
jenkins test make check |
qa/tasks/vstart_runner.py
Outdated
| """ | ||
| return LocalRemote() | ||
|
|
||
| def get_keyring(self, client_id): |
There was a problem hiding this comment.
Can this be inherited via ceph_manager.py?
There was a problem hiding this comment.
Yes, this was supposed to updated after my "inherit" PR got merged.
Done, now. Thanks.
The method wraps very frequently used code-phrase and adds check to avoid potential bugs. Signed-off-by: Rishabh Dave <ridave@redhat.com>
The method wraps very frequently used code-phrase and adds check to
avoid potential bugs.
Checklist
[x] QA improvement
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox