nautilus: librbd: fix sporadic failures in TestMigration.StressLive#41788
Merged
yuriw merged 2 commits intoceph:nautilusfrom Jun 16, 2021
Merged
nautilus: librbd: fix sporadic failures in TestMigration.StressLive#41788yuriw merged 2 commits intoceph:nautilusfrom
yuriw merged 2 commits intoceph:nautilusfrom
Conversation
added 2 commits
June 9, 2021 15:21
This initial version subsumes the original "flatten" boolean flag. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit e79f6b1) Conflicts: src/librbd/deep_copy/ImageCopyRequest.cc (FunctionContext vs LambdaContext, no handler param for ObjectCopyRequest) src/librbd/deep_copy/ObjectCopyRequest.cc src/librbd/deep_copy/ObjectCopyRequest.h src/librbd/io/CopyupRequest.cc src/librbd/operation/MigrateRequest.cc src/test/librbd/deep_copy/test_mock_ImageCopyRequest.cc src/test/librbd/deep_copy/test_mock_ObjectCopyRequest.cc src/test/librbd/io/test_mock_CopyupRequest.cc (no handler param for ObjectCopyRequest)
The migration operation and the copyup state machine will set this flag when attempting to perform a deep-copy due to a live-migration. This flag will prevent a possible race condition between the start of the object deep-copy when migration was enabled and the writing portion of the deep-copy when migration might have completed via external means. Fixes: https://tracker.ceph.com/issues/45694 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 1baba64) Conflicts: src/librbd/deep_copy/ObjectCopyRequest.cc (trivial)
idryomov
approved these changes
Jun 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/48565
backport of #38494
parent tracker: https://tracker.ceph.com/issues/45694
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh