os: let ObjectStore::create() return unique_ptr<> #41520
Merged
tchaikov merged 6 commits intoceph:masterfrom May 29, 2021
Merged
os: let ObjectStore::create() return unique_ptr<> #41520tchaikov merged 6 commits intoceph:masterfrom
tchaikov merged 6 commits intoceph:masterfrom
Conversation
2568ea0 to
bc39a5a
Compare
bc4fd9d to
0f0b03f
Compare
dfe6156 to
41fe970
Compare
Contributor
Author
rzarzynski
reviewed
May 27, 2021
instead of returning a raw pointer of ObjectStore, let `ObjectStore::create()` return a `std::unique_ptr<ObjectStore>`. less error prune this way. Signed-off-by: Kefu Chai <kchai@redhat.com>
less error prune this way. Signed-off-by: Kefu Chai <kchai@redhat.com>
RAII can simplify the clean up logic in OSD::mkfs(). and since `ch` is a smart pointer, so it is able to take care of itself, as long as we ensure that it is destructed before objectstore. Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
less error-prone, and it's simpler to manage the resource using RAII Signed-off-by: Kefu Chai <kchai@redhat.com>
before this change, cot never destructs the created ObjectStore instances. after this change, they are destructed upon returning from main(). Signed-off-by: Kefu Chai <kchai@redhat.com>
41fe970 to
d5445b8
Compare
rzarzynski
approved these changes
May 27, 2021
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox