Skip to content

rgw: crash on multipart upload to bucket with policy#41288

Merged
ofriedma merged 1 commit intoceph:masterfrom
ofriedma:wip-ofriedma-segfault
May 27, 2021
Merged

rgw: crash on multipart upload to bucket with policy#41288
ofriedma merged 1 commit intoceph:masterfrom
ofriedma:wip-ofriedma-segfault

Conversation

@ofriedma
Copy link
Contributor

@ofriedma ofriedma commented May 11, 2021

crash on multipart upload to bucket with policy
Fixes: https://tracker.ceph.com/issues/50556

Signed-off-by: Or Friedmann ofriedma@redhat.com
s3-tests: ceph/s3-tests#393

Copy link
Contributor

@dang dang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I'm not sure I like the shotgun solution to this. Maybe we should set this in rgw_build_bucket_policies(), when s->bucket is created?

@mattbenjamin
Copy link
Contributor

Hmm... I'm not sure I like the shotgun solution to this. Maybe we should set this in rgw_build_bucket_policies(), when s->bucket is created?

that sounds nicer

crash on multipart upload to bucket with policy
Fixes: https://tracker.ceph.com/issues/50556

Signed-off-by: Or Friedmann <ofriedma@redhat.com>
@ofriedma ofriedma force-pushed the wip-ofriedma-segfault branch from cbc593a to 413b23a Compare May 13, 2021 13:01
@ofriedma ofriedma requested a review from dang May 13, 2021 13:42
@cbodley
Copy link
Contributor

cbodley commented May 13, 2021

thanks @ofriedma! in the bug scrub, an s3test case was requested

@tahajahangir
Copy link
Contributor

This is a very annoying bug, makes RGW totally unusable for public buckets. We are waiting for commit of this patch in pacific branch.

@tahajahangir
Copy link
Contributor

In the meanwhile, I suggest committing the patch in a wip-* branch, so others can use a built / docker-image version.

@wtayyeb
Copy link

wtayyeb commented May 15, 2021

we have same problem. we try to build this PR but its too complicated to build it for pacific.

@ofriedma
Copy link
Contributor Author

ofriedma commented May 26, 2021

@ofriedma
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants