mds: make the lost+found dir accessible from clients#40903
Merged
batrick merged 3 commits intoceph:masterfrom May 4, 2021
Merged
mds: make the lost+found dir accessible from clients#40903batrick merged 3 commits intoceph:masterfrom
batrick merged 3 commits intoceph:masterfrom
Conversation
7fa7cff to
deea37a
Compare
batrick
requested changes
Apr 19, 2021
Member
batrick
left a comment
There was a problem hiding this comment.
Great job trackign this down!
Xiubo, can you also add a trivial libcephfs test to lookup:
- root (0x1)
- lost+found (0x4) even if ENOENT
- .ceph (0x2)
jtlayton
approved these changes
Apr 19, 2021
Contributor
jtlayton
left a comment
There was a problem hiding this comment.
Looks good. It kind of sucks that we have a mix of inodes in this range that are accessible via the client and some that aren't, but I think we're stuck with it.
jtlayton
suggested changes
Apr 19, 2021
Member
Author
Sure, I will add it. |
deea37a to
e77be2d
Compare
Member
Author
|
jenkins test make check |
e77be2d to
fb194b8
Compare
jtlayton
reviewed
Apr 20, 2021
jtlayton
approved these changes
Apr 20, 2021
batrick
approved these changes
Apr 20, 2021
fb194b8 to
3030f16
Compare
Member
Author
|
Updated it by fixing the issue pointed out by Luis in kclient, the ino 0x3 will also be lookuped by clients too when checking the snamrealm inos. |
Member
|
ACK |
jtlayton
approved these changes
Apr 23, 2021
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
For inos 1 and 2 there has two places are defining them, to make sure we won't miss any one of them, let's define them in only one header file. Fixes: https://tracker.ceph.com/issues/50216 Signed-off-by: Xiubo Li <xiubli@redhat.com>
Inode number 0x4 is reserved for the lost+found dir, and the apps or recovery apps need to access it. At the same time the 0x3 is reserved for the global snaprealm, which will also be lookup by the clients when looking up the snaprealm inodes. Here will make all the inode less than 100 accessible by clients. Fixes: https://tracker.ceph.com/issues/50216 Signed-off-by: Xiubo Li <xiubli@redhat.com>
Fixes: https://tracker.ceph.com/issues/50216 Signed-off-by: Xiubo Li <xiubli@redhat.com>
3030f16 to
0ec4d78
Compare
Member
Author
|
Rebased to upstream by fixing the conflicts in |
This was referenced May 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inode number 0x4 is reserved for the lost+found dir, and the app
or test app need to access it.
Fixes: https://tracker.ceph.com/issues/50216
Signed-off-by: Xiubo Li xiubli@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox