qa: vstart_runner initilize parent ceph_manager#40868
qa: vstart_runner initilize parent ceph_manager#40868lxbsz wants to merge 1 commit intoceph:masterfrom
Conversation
|
jenkins test api |
Fixes: https://tracker.ceph.com/issues/50373 Signed-off-by: Xiubo Li <xiubli@redhat.com>
rishabh-d-dave
left a comment
There was a problem hiding this comment.
Looks good otherwise. Testing too went fine.
The PR title is outdated. Perhaps, you want to change it for your convenience? :)
| # Deliberately skip parent init, only inheriting from it to get | ||
| # util methods like osd_dump that sit on top of raw_cluster_cmd |
| # Don't bother constructing a map of pools: it should be empty | ||
| # at test cluster start, and in any case it would be out of date | ||
| # in no time. The attribute needs to exist for some of the CephManager | ||
| # methods to work though. |
There was a problem hiding this comment.
I think it's nice to keep this note too.
|
|
||
| self.log = lambda x: log.debug(x) | ||
|
|
There was a problem hiding this comment.
This line got removed here and got shifted below to [1]. It's best to revert this change since the change has no functional or non-functional effect IMO.
| # util methods like osd_dump that sit on top of raw_cluster_cmd | ||
| self.controller = LocalRemote() | ||
|
|
||
| def __init__(self, controller, ctx): |
There was a problem hiding this comment.
ctx isn't used anywhere in the class, it's redundant.
| # in no time. The attribute needs to exist for some of the CephManager | ||
| # methods to work though. | ||
| self.pools = {} | ||
| self.log = lambda x: log.debug(x) |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
Fixes: https://tracker.ceph.com/issues/50373
Signed-off-by: Xiubo Li xiubli@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox