Skip to content

osd: Revert "osd: Try other PGs when reservation failures occur"#40623

Merged
yuriw merged 2 commits intoceph:masterfrom
ronen-fr:wip-ronenf-revert-40077
Apr 9, 2021
Merged

osd: Revert "osd: Try other PGs when reservation failures occur"#40623
yuriw merged 2 commits intoceph:masterfrom
ronen-fr:wip-ronenf-revert-40077

Conversation

@ronen-fr
Copy link
Contributor

@ronen-fr ronen-fr commented Apr 6, 2021

Due to https://tracker.ceph.com/issues/49868

Should be reinstated once that bug is solved. See tracker comments for analysis
and suggested fixes.

@github-actions github-actions bot added the core label Apr 6, 2021
@ronen-fr ronen-fr requested a review from neha-ojha April 6, 2021 15:12
Copy link
Member

@neha-ojha neha-ojha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since https://tracker.ceph.com/issues/49868 is showing up in almost every rados run, makes sense to revert the relevant commits and merge back with the fix.

@ronen-fr nit: you can add the reason for reverting this change in the commit message as well

ronen-fr added 2 commits April 7, 2021 08:37
This reverts commit dd63577.

As 08c3ede (the tested functionality) is reverted.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
This reverts commit 08c3ede.

Due to https://tracker.ceph.com/issues/49868
Should be reinstated once that bug is solved. See tracker comments for analysis
and suggested fixes.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
@ronen-fr ronen-fr force-pushed the wip-ronenf-revert-40077 branch from d295e10 to c57731d Compare April 7, 2021 05:39
@ronen-fr
Copy link
Contributor Author

ronen-fr commented Apr 7, 2021

@neha-ojha:

@ronen-fr nit: you can add the reason for reverting this change in the commit message as well

Done

@ronen-fr ronen-fr requested a review from neha-ojha April 7, 2021 05:40
@yuriw yuriw merged commit 5f2f793 into ceph:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants