osd: recover unreadable snapshot before reading refcount info#40606
Merged
yuriw merged 1 commit intoceph:masterfrom Apr 9, 2021
Merged
osd: recover unreadable snapshot before reading refcount info#40606yuriw merged 1 commit intoceph:masterfrom
yuriw merged 1 commit intoceph:masterfrom
Conversation
Member
|
@myoungwon I created https://tracker.ceph.com/issues/50192 to track the issue this PR is fixing. This needs to be backported to pacific, right? |
Member
Author
|
@neha-ojha Right. |
athanatos
reviewed
Apr 7, 2021
src/osd/PrimaryLogPG.cc
Outdated
| bool PrimaryLogPG::recover_adjacent_clones(ObjectContextRef obc, OpRequestRef op) | ||
| { | ||
| if (!obc->obs.oi.manifest.is_chunked() || !obc->ssc || !obc->ssc->snapset.clones.size()) { | ||
| if (!obc->obs.oi.manifest.is_chunked() || !obc->ssc || !obc->ssc->snapset.clones.size() || !op) { |
Contributor
There was a problem hiding this comment.
Do any callers pass op as nullptr?
Manifest objects needs adjacent clones when incrementing/decrementing refcount. This commit makes the current code to call get_manifest_ref_count before reading ref. count info. Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
athanatos
approved these changes
Apr 8, 2021
14 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manifest objects need adjacent clones when incrementing/decrementing
refcount. This commit makes the current code to call get_manifest_ref_count
before reading ref. count info.
fixes: https://tracker.ceph.com/issues/49427#change-189520
Signed-off-by: Myoungwon Oh myoungwon.oh@samsung.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox