Skip to content

nautilus: test/pybind: s/nosetests/python3/#40536

Merged
tchaikov merged 3 commits intoceph:nautilusfrom
tchaikov:nautilus-nose-py3
Apr 1, 2021
Merged

nautilus: test/pybind: s/nosetests/python3/#40536
tchaikov merged 3 commits intoceph:nautilusfrom
tchaikov:nautilus-nose-py3

Conversation

@tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Apr 1, 2021 •
edited
Loading

we still support python2 in nautilus. but we need to run "make check" in python3. hence the change.

this change should address the test failure like

117/180 Test #163: test_ceph_daemon.py .....................***Failed    0.04 sec
/usr/bin/env: 'nosetests': No such file or directory

see https://jenkins.ceph.com/job/ceph-pull-requests/72581/console

different distros package python3-nose in different ways by adding
different postfix to "/usr/bin/nosetests" to differentiate it from
its python2 counterpart.

  • on bionic, python3-nose offers "nosetests3"
  • on el8, python3-nose offers "nosetests-3" and "nosetests-3.6"

Signed-off-by: Kefu Chai kchai@redhat.com
(cherry picked from commit 717aaad)

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@tchaikov
test/pybind: s/nosetests/python3/
f01c95f 
different distros package python3-nose in different ways by adding
different postfix to "/usr/bin/nosetests" to differentiate it from
its python2 counterpart.

* on bionic, python3-nose offers "nosetests3"
* on el8, python3-nose offers "nosetests-3" and "nosetests-3.6"

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 717aaad)
@github-actions github-actions bot added this to the nautilus milestone Apr 1, 2021
@tchaikov tchaikov requested a review from badone April 1, 2021 03:28
@tchaikov tchaikov mentioned this pull request Apr 1, 2021
Closed
3 tasks
@tchaikov tchaikov force-pushed the nautilus-nose-py3 branch from 7c351f5 to ccbda45 Compare April 1, 2021 04:28
@tchaikov tchaikov mentioned this pull request Apr 1, 2021
Merged
@tchaikov
Copy link
Contributor Author

tchaikov commented Apr 1, 2021

jenkins test make check

@tchaikov tchaikov force-pushed the nautilus-nose-py3 branch from aef4a3d to 15071f3 Compare April 1, 2021 06:31
@tchaikov tchaikov requested a review from alfonsomthd April 1, 2021 06:33
@tchaikov
Copy link
Contributor Author

tchaikov commented Apr 1, 2021

jenkins test api

@tchaikov
Copy link
Contributor Author

tchaikov commented Apr 1, 2021

jenkins test make check

@tchaikov tchaikov force-pushed the nautilus-nose-py3 branch from 15071f3 to db54943 Compare April 1, 2021 06:54
@alfonsomthd
Copy link
Contributor

alfonsomthd commented Apr 1, 2021

jenkins test make check

@tchaikov tchaikov force-pushed the nautilus-nose-py3 branch from db54943 to 1926509 Compare April 1, 2021 07:32
tchaikov added 2 commits April 1, 2021 16:05
@tchaikov
mgr/dashboard: do not import tools in access_control
e2614de 
this addresses a regression introduced by
2cd9429. which

from ..tools import ensure_str

and it causes recursive import.

so, in this change, an copy of ensure_str() is added
to access_control.py

this change is not cherry-picked from master, as the offending commit
which is fixed by this change is not included in master.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
pybind/mgr/dashboard/.pylintrc: silence more pylint warnings
c8f0b79 
this change is not cherry-picked from master, as we don't have following
warnings in master, like:

************* Module dashboard.controllers.saml2
        intern-builtin,
controllers/saml2.py:57:8: R1720: Unnecessary "else" after "raise" (no-else-raise)

also bump up the versions of pylint and astroid, so they
can work with python3.8.

see
pylint-dev/astroid@28fc86f

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov force-pushed the nautilus-nose-py3 branch 2 times, most recently from ef15fc4 to c8f0b79 Compare April 1, 2021 08:31
@tchaikov
Copy link
Contributor Author

tchaikov commented Apr 1, 2021 

[----------] 1 test from TestOSDScrub
[ RUN      ] TestOSDScrub.scrub_time_permit
2021-04-01 08:12:03.040 7f42d0dc2880 -1 Errors while parsing config file!
2021-04-01 08:12:03.040 7f42d0dc2880 -1 parse_file: cannot open /etc/ceph/ceph.conf: (2) No such file or directory
2021-04-01 08:12:03.040 7f42d0dc2880 -1 parse_file: cannot open /home/jenkins-build/.ceph/ceph.conf: (2) No such file or directory
2021-04-01 08:12:03.040 7f42d0dc2880 -1 parse_file: cannot open ceph.conf: (2) No such file or directory
2021-04-01 08:12:03.040 7f42d0dc2880 -1 Errors while parsing config file!
2021-04-01 08:12:03.040 7f42d0dc2880 -1 parse_file: cannot open /etc/ceph/ceph.conf: (2) No such file or directory
2021-04-01 08:12:03.040 7f42d0dc2880 -1 parse_file: cannot open /home/jenkins-build/.ceph/ceph.conf: (2) No such file or directory
2021-04-01 08:12:03.040 7f42d0dc2880 -1 parse_file: cannot open ceph.conf: (2) No such file or directory
2021-04-01 08:12:03.044 7f42d0dc2880 -1 auth: unable to find a keyring on /etc/ceph/ceph.client.admin.keyring,/etc/ceph/ceph.keyring,/etc/ceph/keyring,/etc/ceph/keyring.bin,: (2) No such file or directory
2021-04-01 08:12:03.044 7f42d0dc2880 -1 AuthRegistry(0x55ccd0714140) no keyring found at /etc/ceph/ceph.client.admin.keyring,/etc/ceph/ceph.keyring,/etc/ceph/keyring,/etc/ceph/keyring.bin,, disabling cephx
unable to get monitor info from DNS SRV with service name: ceph-mon
2021-04-01 08:12:03.064 7f42d0dc2880 -1 failed for service _ceph-mon._tcp
2021-04-01 08:12:03.064 7f42d0dc2880 -1 bluestore(/var/lib/ceph/osd/ceph-admin) _open_path unable to open /var/lib/ceph/osd/ceph-admin: (2) No such file or directory
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/osd/TestOSDScrub.cc:117: Failure
Value of: ret
  Actual: true
Expected: false
[  FAILED  ] TestOSDScrub.scrub_time_permit (24 ms)

@tchaikov tchaikov merged commit fd6dd0d into ceph:nautilus Apr 1, 2021
@tchaikov tchaikov deleted the nautilus-nose-py3 branch April 1, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@badone badone badone approved these changes

@alfonsomthd alfonsomthd alfonsomthd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

nautilus

Development

Successfully merging this pull request may close these issues.

3 participants

@tchaikov @alfonsomthd @badone