mgr/PyModule: put mgr_module_path before Py_GetPath()#40505
Merged
tchaikov merged 1 commit intoceph:masterfrom Mar 31, 2021
Merged
mgr/PyModule: put mgr_module_path before Py_GetPath()#40505tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
4a00c26 to
2acf592
Compare
pip comes with _vendor/progress. so there is chance to import the vendored version of "progress" module instead of the "progress" mgr module, and fail to import the latter. in this change, the order of paths are rearranged so the configured `mgr_module_path` is put before the return value of `Py_GetPath()`. Fixes: https://tracker.ceph.com/issues/50058 Signed-off-by: Kefu Chai <kchai@redhat.com>
jdurgin
approved these changes
Mar 30, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/50058
Signed-off-by: Kefu Chai kchai@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox