pybind/mgr/volumes: avoid deadlock in ceph-mgr Finisher thread#40316
Merged
tchaikov merged 4 commits intoceph:masterfrom Apr 3, 2021
Merged
pybind/mgr/volumes: avoid deadlock in ceph-mgr Finisher thread#40316tchaikov merged 4 commits intoceph:masterfrom
tchaikov merged 4 commits intoceph:masterfrom
Conversation
d20babf to
22e4c98
Compare
batrick
commented
Mar 23, 2021
tchaikov
reviewed
Mar 23, 2021
df3ea3c to
4b5dc62
Compare
kotreshhr
reviewed
Mar 23, 2021
humblec
reviewed
Mar 23, 2021
10c9484 to
9cab094
Compare
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Hunting [1]. [1] https://tracker.ceph.com/issues/49605 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Perform thread count updates in a dedicated tick thread. This avoids the mgr Finisher thread from getting potentially hung via a mutex deadlock in the cloner thread management. Fixes: https://tracker.ceph.com/issues/49605 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Contributor
|
@batrick changes look good. hoping to catch potential locking issues... |
Member
Author
|
Member
Author
|
Ready to merge. |
tchaikov
reviewed
Mar 27, 2021
There is a hang in get_job which is holding the mutex [1]. This debug output is meant to help find this issue in upstream QA logs. [1] https://tracker.ceph.com/issues/49605#note-5 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Member
Author
|
Thanks @tchaikov , I've adopted most of your suggestions. |
Contributor
|
jenkins test api |
kotreshhr
approved these changes
Mar 31, 2021
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox