qa/tasks/cephadm: use 'orch apply mon' to deploy mons#40314
Merged
liewegas merged 1 commit intoceph:masterfrom Mar 24, 2021
Merged
qa/tasks/cephadm: use 'orch apply mon' to deploy mons#40314liewegas merged 1 commit intoceph:masterfrom
liewegas merged 1 commit intoceph:masterfrom
Conversation
jmolmo
approved these changes
Mar 22, 2021
adc5dd4 to
68ab16a
Compare
b84b43f to
e7ec7e6
Compare
The 'orch daemon add ...' command is not idempotent and can cause duplicate (and failing) attempts to add the same mon. Maintain the ability to add mons the old way for the benefit of testing upgrades from early octopus versions of cephadm. Signed-off-by: Sage Weil <sage@newdream.net>
e7ec7e6 to
a17593a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'orch daemon add ...' command is not idempotent and can cause
duplicate (and failing) attempts to add the same mon.
Signed-off-by: Sage Weil sage@newdream.net