mon/MgrStatMonitor: ignore MMgrReport from non-active mgr#40219
Merged
liewegas merged 2 commits intoceph:masterfrom Mar 20, 2021
Merged
mon/MgrStatMonitor: ignore MMgrReport from non-active mgr#40219liewegas merged 2 commits intoceph:masterfrom
liewegas merged 2 commits intoceph:masterfrom
Conversation
Otherwise, when we re-subscribe we'll request an old map again. In the case of the servicemap, that can lead to a failed assertion. Fixes: https://tracker.ceph.com/issues/48022 Signed-off-by: Sage Weil <sage@newdream.net>
If it's not the active mgr, we should ignore it. Since the mgr instance is best identified by the gid, add that to the message. (We can't use the source_addrs for the message since that is the MgrStandby monc addr, not the active mgr addrs in the MgrMap.) This fixes a problem where a just-demoted mgr report gets processed and a new mgr gets a ServiceMap with an epoch >= its pending map. (At least, that is my theory!) Fixes: https://tracker.ceph.com/issues/48022 Signed-off-by: Sage Weil <sage@newdream.net>
neha-ojha
approved these changes
Mar 19, 2021
trociny
approved these changes
Mar 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/48022