Skip to content

mgr/volumes: Retain suid guid bits in clone#40214

Merged
batrick merged 3 commits intoceph:masterfrom
kotreshhr:retain-suid-guid-bits-in-clone
Mar 20, 2021
Merged

mgr/volumes: Retain suid guid bits in clone#40214
batrick merged 3 commits intoceph:masterfrom
kotreshhr:retain-suid-guid-bits-in-clone

Conversation

@kotreshhr
Copy link
Contributor

@kotreshhr kotreshhr commented Mar 18, 2021

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@kotreshhr kotreshhr changed the title Retain suid guid bits in clone mgr/volumes: Retain suid guid bits in clone Mar 18, 2021
@github-actions github-actions bot added cephfs Ceph File System pybind labels Mar 18, 2021
@kotreshhr kotreshhr marked this pull request as draft March 18, 2021 13:03
@kotreshhr kotreshhr force-pushed the retain-suid-guid-bits-in-clone branch from d8aa479 to e163c50 Compare March 18, 2021 15:04
@github-actions github-actions bot added the tests label Mar 18, 2021
@kotreshhr kotreshhr force-pushed the retain-suid-guid-bits-in-clone branch from e163c50 to 8fc1e45 Compare March 18, 2021 15:24
@kotreshhr kotreshhr requested review from ajarr and batrick March 18, 2021 15:48
@kotreshhr kotreshhr marked this pull request as ready for review March 18, 2021 16:03
@kotreshhr
Copy link
Contributor Author

kotreshhr commented Mar 18, 2021

jenkins test make check

batrick
batrick requested changes Mar 18, 2021
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm; great work!

@kotreshhr kotreshhr force-pushed the retain-suid-guid-bits-in-clone branch from 8fc1e45 to 9ba99e3 Compare March 18, 2021 16:54
batrick
batrick approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run through testing.

@ajarr
Copy link
Contributor

ajarr commented Mar 18, 2021

teuthology testing with --filter volumes,libcephfs_python,tasks/libcephfs
http://pulpito.front.sepia.ceph.com/rraja-2021-03-18_22:56:35-fs-wip-khiremat-40214-retain-suid-subvol-clone-distro-basic-smithi/

@ajarr
Copy link
Contributor

ajarr commented Mar 19, 2021

teuthology testing with --filter volumes,libcephfs_python,tasks/libcephfs
http://pulpito.front.sepia.ceph.com/rraja-2021-03-18_22:56:35-fs-wip-khiremat-40214-retain-suid-subvol-clone-distro-basic-smithi/

Test failures seem unrelated.
I have not seen this before,
http://pulpito.front.sepia.ceph.com/rraja-2021-03-18_22:56:35-fs-wip-khiremat-40214-retain-suid-subvol-clone-distro-basic-smithi/5978421/
newly added lchmod test passes, but symlinks test fails

@kotreshhr
Copy link
Contributor Author

kotreshhr commented Mar 19, 2021

teuthology testing with --filter volumes,libcephfs_python,tasks/libcephfs
http://pulpito.front.sepia.ceph.com/rraja-2021-03-18_22:56:35-fs-wip-khiremat-40214-retain-suid-subvol-clone-distro-basic-smithi/

Test failures seem unrelated.
I have not seen this before,
http://pulpito.front.sepia.ceph.com/rraja-2021-03-18_22:56:35-fs-wip-khiremat-40214-retain-suid-subvol-clone-distro-basic-smithi/5978421/
newly added lchmod test passes, but symlinks test fails

I think it runs as single process and the symlink file names are conflicting between 'Lchmod' and "Symlinks" tests. I will change and refresh this PR.

@kotreshhr
client/libcephfs: Add lchmod
bb1fd87 
Fixes: https://tracker.ceph.com/issues/49882
Signed-off-by: Kotresh HR <khiremat@redhat.com>
@kotreshhr
pybind/cephfs: Add lchmod python binding
b2375ad 
Fixes: https://tracker.ceph.com/issues/49882
Signed-off-by: Kotresh HR <khiremat@redhat.com>
@kotreshhr
mgr/volumes: Retain suid/guid bits in subvolume clone
92dc982 
Fixes: https://tracker.ceph.com/issues/49882
Signed-off-by: Kotresh HR <khiremat@redhat.com>
@kotreshhr kotreshhr force-pushed the retain-suid-guid-bits-in-clone branch from 9ba99e3 to 92dc982 Compare March 19, 2021 04:00
@kotreshhr
Copy link
Contributor Author

kotreshhr commented Mar 19, 2021

jenkins test api

@kotreshhr
Copy link
Contributor Author

kotreshhr commented Mar 19, 2021 •
edited
Loading

Teuthology results:

http://pulpito.front.sepia.ceph.com/khiremat-2021-03-19_05:25:43-fs-wip-khiremat-40214-retain-suid-subvol-clone-1-distro-basic-smithi/

The symlink testcase is fixed, but few unrelated failures.

  1. test_subvolume_evict_client - Umount failed on system, not the first time
  2. test_subvolumegroup_pin_distributed - Known failure
  3. Teuthology traced back as below:
    teuthology.exceptions.CommandFailedError: Command failed on smithi205 with status 123: "find /home/ubuntu/cephtest/archive/syslog -name '*.log' -print0 | sudo xargs -0 --no-run-if-empty -- gzip --"

@kotreshhr
Copy link
Contributor Author

kotreshhr commented Mar 19, 2021

jenkins test make check

@kotreshhr
Copy link
Contributor Author

kotreshhr commented Mar 19, 2021

jenkins test api

@batrick
Copy link
Member

batrick commented Mar 20, 2021

LGTM

@batrick batrick merged commit b4dceb0 into ceph:master Mar 20, 2021
This was referenced Mar 20, 2021
Merged
Merged
@kotreshhr kotreshhr mentioned this pull request Mar 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@batrick batrick batrick approved these changes

@ajarr ajarr ajarr approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System pybind tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kotreshhr @ajarr @batrick