Skip to content

test/lazy-omap-stats: Various enhancements#39980

Merged
jdurgin merged 1 commit intoceph:mainfrom
badone:wip-ceph_test_lazy_omap_stats-improve-scrubbing-calls-2
Jun 17, 2022
Merged

test/lazy-omap-stats: Various enhancements#39980
jdurgin merged 1 commit intoceph:mainfrom
badone:wip-ceph_test_lazy_omap_stats-improve-scrubbing-calls-2

Conversation

@badone
Copy link
Contributor

@badone badone commented Mar 10, 2021 •
edited
Loading

Primarily removal of boost::process call to blocking deep scrub cli
command.

Signed-off-by: Brad Hubbard bhubbard@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@badone badone requested review from jdurgin and neha-ojha March 10, 2021 00:51
@badone
Copy link
Contributor Author

badone commented Mar 10, 2021

@neha-ojha @jdurgin Changes as discussed.

@badone badone force-pushed the wip-ceph_test_lazy_omap_stats-improve-scrubbing-calls-2 branch from 9b12302 to d417798 Compare March 11, 2021 03:33
@badone
Copy link
Contributor Author

badone commented Mar 11, 2021

Added a sleep to the "scrub()" method which should fix https://tracker.ceph.com/issues/49727

@dzafman
Copy link
Contributor

dzafman commented Mar 11, 2021

Added a sleep to the "scrub()" method which should fix https://tracker.ceph.com/issues/49727

Add the tracker URL to the commit comment. Separate the sleep into a different commit if you like. Use the tracker to backport at least the sleep to Pacific. Or maybe it doesn't impact Pacific since it is a test fix.

@stale
Copy link

stale bot commented Jul 21, 2021

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Jul 21, 2021
@neha-ojha
Copy link
Member

neha-ojha commented Jul 21, 2021

This is still useful, unstale.

@stale stale bot removed the stale label Jul 21, 2021
@github-actions
Copy link

github-actions bot commented Jul 24, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Jan 9, 2022
@rzarzynski rzarzynski removed the stale label Mar 22, 2022
@rzarzynski
Copy link
Contributor

rzarzynski commented Mar 22, 2022

we still want this!

@badone
Copy link
Contributor Author

badone commented Mar 23, 2022 •
edited
Loading

Re-engaged on this.

@badone
test/lazy-omap-stats: Various enhancements
c3e28a8 
Primarily removal of boost::process call to blocking deep scrub cli
command.

Fixes: https://tracker.ceph.com/issues/49727

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
@badone badone force-pushed the wip-ceph_test_lazy_omap_stats-improve-scrubbing-calls-2 branch from d417798 to c3e28a8 Compare March 25, 2022 02:07
@badone
Copy link
Contributor Author

badone commented Mar 25, 2022

http://pulpito.front.sepia.ceph.com/bhubbard-2022-03-25_01:22:23-rados-wip-badone-testing-distro-basic-smithi/

@badone badone requested a review from rzarzynski March 25, 2022 02:07
@badone
Copy link
Contributor Author

badone commented Mar 25, 2022

I've brought this up to date. Could I get a review please guys?

@badone
Copy link
Contributor Author

badone commented Apr 10, 2022

@rzarzynski would you have time to review this mate so we can get it finished? Thanks.

@badone
Copy link
Contributor Author

badone commented Jun 15, 2022

@anyone ?

@badone badone added core and removed build/ops labels Jun 15, 2022
@badone badone changed the base branch from master to main June 17, 2022 01:54
@badone
Copy link
Contributor Author

badone commented Jun 17, 2022

jenkins retest this please

@jdurgin jdurgin merged commit 7af94d1 into ceph:main Jun 17, 2022
@rzarzynski rzarzynski mentioned this pull request Sep 2, 2022
Merged
@badone badone deleted the wip-ceph_test_lazy_omap_stats-improve-scrubbing-calls-2 branch January 8, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdurgin jdurgin jdurgin approved these changes

@neha-ojha neha-ojha Awaiting requested review from neha-ojha

@rzarzynski rzarzynski Awaiting requested review from rzarzynski

Assignees

No one assigned

Labels

core tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@badone @dzafman @neha-ojha @rzarzynski @jdurgin