cephadm: add docker.service dependency in systemd units#39770
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Mar 3, 2021
Merged
cephadm: add docker.service dependency in systemd units#39770sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp merged 1 commit intoceph:masterfrom
Conversation
Contributor
|
Would be great to have a unit test for this. Maybe calling |
This ensures that (1) we start after the docker daemon is running, and (2) a restart of docker will also restart the ceph services. Fixes: https://tracker.ceph.com/issues/46745 Signed-off-by: Sage Weil <sage@newdream.net>
sebastian-philipp
approved these changes
Mar 2, 2021
Member
Author
|
jenkins test make check |
This was referenced Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that (1) we start after the docker daemon is running, and
(2) a restart of docker will also restart the ceph services.
Fixes: https://tracker.ceph.com/issues/46745
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox