cephadm: fix escaping/quoting of stderr-prefix arg for ceph daemons#39730
Merged
liewegas merged 1 commit intoceph:masterfrom Mar 2, 2021
Merged
cephadm: fix escaping/quoting of stderr-prefix arg for ceph daemons#39730liewegas merged 1 commit intoceph:masterfrom
liewegas merged 1 commit intoceph:masterfrom
Conversation
4f6e021 to
13befd6
Compare
Contributor
13befd6 to
1249522
Compare
sebastian-philipp
approved these changes
Mar 2, 2021
mgfritch
approved these changes
Mar 2, 2021
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
On some versions of podman doing --default-log-stderr-prefix="debug " seems to work okay, but on others it does not, producing lines like /usr/bin/ceph-mon: "debug "2021-02-26T15:30:36.266+0000 7f3d8a955700 4 rocksdb: Options.db_write_buffer_size: 0 Quote things properly for the unit.run bash script. Signed-off-by: Sage Weil <sage@newdream.net>
1249522 to
3ea514c
Compare
3 tasks
Member
|
This PR has introduced a regression, custom containers (type='container') can not be deployed anymore. The It was possible to deploy whatever Docker container before this PR, e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cephadm: fix escaping/quoting of stderr-prefix arg for ceph daemons