osd: fix missing adjacent snaps when handling manifest object#39670
Merged
tchaikov merged 2 commits intoceph:masterfrom Mar 12, 2021
Merged
osd: fix missing adjacent snaps when handling manifest object#39670tchaikov merged 2 commits intoceph:masterfrom
tchaikov merged 2 commits intoceph:masterfrom
Conversation
At the end of unit test, flush and evict are called. But, those ops affect manifest object because cache_mode is not set to NONE sometime. Signed-off-by: Myoungwon Oh <myoungwon.oh@samsumg.com>
The manifest object needs adjacent clones to increment/decrement refcount when modifying the object. So, recovering the clones is needed if the adjacent clones are unreadable. Signed-off-by: Myoungwon Oh <myoungwon.oh@samsumg.com>
d275549 to
b242a2c
Compare
Member
Author
|
@athanatos hmm.. What do you think? |
Contributor
|
This might work, but I'm going to have to go through this carefully. |
Contributor
|
I think this should work. |
athanatos
approved these changes
Mar 1, 2021
Contributor
athanatos
left a comment
There was a problem hiding this comment.
LGTM pending a test run (also, remove the WIP:)
Contributor
Contributor
|
the failures are tracked by https://tracker.ceph.com/issues/49726 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manifest object needs adjacent clones to increment/decrement
refcount when acessing the object. So, recover the clones first
if there are missing clones.
Fixes: https://tracker.ceph.com/issues/49427
Signed-off-by: Myoungwon Oh myoungwon.oh@samsung.com