tests: ceph_test_rados_api_watch_notify: Allow for reconnect#39601
Merged
badone merged 1 commit intoceph:masterfrom Mar 1, 2021
Merged
Conversation
An injected socket failure may cause rados_watch_check() to return ENOENT instead of the expected ENOTCONN. Fixes: https://tracker.ceph.com/issues/47719 Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
Contributor
Author
|
jenkins test make check |
Contributor
Author
neha-ojha
approved these changes
Feb 22, 2021
Member
neha-ojha
left a comment
There was a problem hiding this comment.
Your analysis in https://tracker.ceph.com/issues/47719#note-9 makes sense to me, we could further verify your theory by removing failure injection from these tests and see if we hit the issue.
Member
|
make check failure tracked in https://tracker.ceph.com/issues/49426 |
Member
|
jenkins test make check |
Contributor
Author
|
I ran 50 tests with msgr-failures and 50 without. With msgr-failures I saw multiple failures (all have trackers) including three instances of this issue. Without msgr-failures I still saw multiple failures but I saw no instances of this specific issue. |
Contributor
Author
|
jenkins test make check |
1 similar comment
Contributor
Author
|
jenkins test make check |
3 tasks
This was referenced Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An injected socket failure may cause rados_watch_check() to return
ENOENT instead of the expected ENOTCONN.
Fixes: https://tracker.ceph.com/issues/47719
Signed-off-by: Brad Hubbard bhubbard@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox