cephadm: version command hide traceback when login is needed#39562
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Feb 24, 2021
Merged
Conversation
adk3798
approved these changes
Feb 18, 2021
sebastian-philipp
suggested changes
Feb 19, 2021
src/cephadm/cephadm
Outdated
| out = CephContainer(ctx, ctx.image, 'ceph', ['--version']).run() | ||
| print(out.strip()) | ||
| except Exception: | ||
| pass |
Contributor
There was a problem hiding this comment.
though, we should not return 0 if that fails.
Author
There was a problem hiding this comment.
podman return code is passed along
9f367a7 to
db3e802
Compare
sebastian-philipp
approved these changes
Feb 19, 2021
db3e802 to
bb88caa
Compare
if image comes from a authenticated registry and login has not been done yet the traceback should be hidden and only show the error message Signed-off-by: Daniel Pivonka <dpivonka@redhat.com>
bb88caa to
4c1c656
Compare
Contributor
|
jenkins test api |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if image comes from a authenticated registry and login has not been done yet the traceback should be hidden and only show the error message
traceback shown before
after no traceback
Fixes: https://tracker.ceph.com/issues/49366
Signed-off-by: Daniel Pivonka dpivonka@redhat.com