mgr/cephadm: remove spec from CephadmDaemonDeploySpec#39495
Merged
liewegas merged 1 commit intoceph:masterfrom Feb 21, 2021
Merged
mgr/cephadm: remove spec from CephadmDaemonDeploySpec#39495liewegas merged 1 commit intoceph:masterfrom
liewegas merged 1 commit intoceph:masterfrom
Conversation
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
9c3b077 to
07a9229
Compare
adk3798
approved these changes
Feb 17, 2021
Contributor
adk3798
left a comment
There was a problem hiding this comment.
Like this change. Tested locally deploying/redeploying some services whose service files changed (e.g. alertmanager and ha-rgw) and everything looked good.
07a9229 to
9d07138
Compare
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
9d07138 to
d8bcaac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a bunch of untested code that broke in previous PRs already
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox