mgr/dashboard: check .badge instead of text for expected label#39363
Merged
tchaikov merged 1 commit intoceph:masterfrom Feb 17, 2021
Merged
mgr/dashboard: check .badge instead of text for expected label#39363tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
tchaikov
reviewed
Feb 9, 2021
Contributor
tchaikov
left a comment
There was a problem hiding this comment.
@nizamial09 could you revise the commit message like
mgr/dashboard: check .badge instead of text for expected label
this change fixes a regression introduced by
8c5e31ec1a13bc53394eb2cb6880d74db169fac4 which broke the 01-hosts.e2e-spec.ts test
driven by test_dashboard_e2e.sh
Fixes: https://tracker.ceph.com/issues/49205
Signed-off-by: Nizamudeen A <nia@redhat.com>
?
Contributor
fd92e62 to
93f813f
Compare
Member
Author
|
@tchaikov Update the commit message and title. |
epuertat
approved these changes
Feb 9, 2021
Member
epuertat
left a comment
There was a problem hiding this comment.
Thanks for the quick fix @nizamial09 !
aaSharma14
approved these changes
Feb 10, 2021
Contributor
|
@nizamial09 could you please rerun the failed test to verify the fix? i tried to run it twice. but both runs timed out. see my another comment in this PR. |
Member
Author
|
@tchaikov I've been trying for getting the e2e done locally but I couldn't do it succefully since this requires an orchestrator e2e to be run. |
avanthakkar
approved these changes
Feb 15, 2021
this change fixes a regression introduced by 8c5e31e which broke the 01-hosts.e2e-spec.ts test driven by test_dashboard_e2e.sh Fixes: https://tracker.ceph.com/issues/49205 Signed-off-by: Nizamudeen A <nia@redhat.com>
93f813f to
6156055
Compare
Member
Author
tchaikov
approved these changes
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e2e got broke after this PR: #39229
Fixes: https://tracker.ceph.com/issues/49205
Signed-off-by: Nizamudeen A nia@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox