qa/workunits/cephadm/test_cephadm: some cleanup#39097
Merged
liewegas merged 6 commits intoceph:masterfrom Jan 30, 2021
Merged
Conversation
Member
liewegas
commented
Jan 27, 2021
- don't pull old images
- remove cruft for testing python2
We aren't supporting python2 anymore. Signed-off-by: Sage Weil <sage@newdream.net>
…ceph.io No reason to pull nautilus/mimic, which don't even support cephadm. This test will mostly run in the sepia lab, so pull from there. Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Sage Weil <sage@newdream.net>
sebastian-philipp
approved these changes
Jan 27, 2021
mgfritch
approved these changes
Jan 27, 2021
Contributor
mgfritch
left a comment
There was a problem hiding this comment.
one minor suggestion, otherwise lgtm!
| local units="nfs-server nfs-kernel-server" | ||
| for unit in $units; do | ||
| if systemctl status $unit; then | ||
| if systemctl status $unit < /dev/null; then |
Contributor
There was a problem hiding this comment.
Suggested change
| if systemctl status $unit < /dev/null; then | |
| if systemctl status $unit > /dev/null; then |
Member
Author
There was a problem hiding this comment.
I tried that first, but it doesn't prevent systemctl status from launching the pager; > does
Contributor
There was a problem hiding this comment.
maybe systemctl --no-pager ?
Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Sage Weil <sage@newdream.net>
7cd5666 to
8c625c0
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.