cephadm: require podman >= 2.0.2#39007
Merged
sebastian-philipp merged 4 commits intoceph:masterfrom Jan 29, 2021
Merged
Conversation
Contributor
Author
|
Tested on ubuntu bionic, openSUSE tumbleweed, and CentOS 8.0. Most cephadm commands will require podman >= 2.0: check-host will also verify the version: A subsequent run of |
This was referenced Jan 21, 2021
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Contributor
|
In and in Would it be a good idea for this PR to change that to: and ? |
Contributor
|
RATIONALE: It seems weird for the package manager to install podman as a dependency, only for cephadm to refuse to work with it because the podman version is too old. |
consolidate the logic for making a container engine selection Signed-off-by: Michael Fritch <mfritch@suse.com>
0abc89c to
44dc0ed
Compare
sebastian-philipp
approved these changes
Jan 26, 2021
Fixes: https://tracker.ceph.com/issues/47139 Signed-off-by: Michael Fritch <mfritch@suse.com>
remove technical debt related to podman < 2.0.0 Signed-off-by: Michael Fritch <mfritch@suse.com>
Signed-off-by: Michael Fritch <mfritch@suse.com>
44dc0ed to
a899227
Compare
Contributor
|
I'm super surprised that the run passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/47139
Signed-off-by: Michael Fritch mfritch@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox