mgr/cephadm: raise HEALTH_WARN when cephadm daemon in 'error' state#38978
Merged
sebastian-philipp merged 2 commits intoceph:masterfrom Jan 22, 2021
Merged
mgr/cephadm: raise HEALTH_WARN when cephadm daemon in 'error' state#38978sebastian-philipp merged 2 commits intoceph:masterfrom
sebastian-philipp merged 2 commits intoceph:masterfrom
Conversation
We need to update the self.health_checks dict and use that or else we will clobber any other exising checks. Signed-off-by: Sage Weil <sage@newdream.net>
If cephadm daemons are not happy we should raise a warning. Aside from being an important part of the user experience, this will also help us catch teuthology test errors. Fixes: https://tracker.ceph.com/issues/45628 Signed-off-by: Sage Weil <sage@newdream.net>
jmolmo
approved these changes
Jan 21, 2021
sebastian-philipp
approved these changes
Jan 22, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/45628