qa/rgw: reenable valgrind in rgw/verify suite#38871
Merged
cbodley merged 3 commits intoceph:masterfrom Feb 9, 2021
Merged
Conversation
Contributor
Author
|
also testing a commit that unpins centos and runs against |
Contributor
Author
it looks like we only build notcmalloc packages for centos, so we can't schedule valgrind runs against other distros |
cd3ad40 to
3b108aa
Compare
3b108aa to
68742af
Compare
Contributor
Author
|
rebased to pull in the --exit-on-first-error fix from #38966 |
Signed-off-by: Casey Bodley <cbodley@redhat.com>
this only enables it for radosgw itself, not the other daemons Signed-off-by: Casey Bodley <cbodley@redhat.com>
the 'sudo netstat | grep radosgw' command is causing failures:
File "qa/workunits/rgw/test_rgw_reshard.py", line 53, in get_radosgw_port
x = out.decode('utf8').split(" ")
AttributeError: 'bool' object has no attribute 'decode'
because when valgrind is enabled, the process name is 'valgrind' instead
of 'radosgw'
Signed-off-by: Casey Bodley <cbodley@redhat.com>
68742af to
a635e52
Compare
Contributor
Author
|
@yuvalif @alimaredia I think we're ready to turn this on, even if we do see some intermittent failures |
alimaredia
approved these changes
Feb 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this had been disabled during py3 conversion when we had to pin ubuntu, but never turned back on when we switched back to centos
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox