os/bluestore: introduce new "per-pg" naming scheme for omap#38651
Merged
tchaikov merged 1 commit intoceph:masterfrom Jan 1, 2021
Merged
os/bluestore: introduce new "per-pg" naming scheme for omap#38651tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
jdurgin
approved these changes
Dec 22, 2020
Member
jdurgin
left a comment
There was a problem hiding this comment.
Logic looks sound, we probably need a release note / docs about running fsck if we don't have that already for the bluestore format changes
602a78a to
5cac644
Compare
aclamk
approved these changes
Dec 22, 2020
Contributor
aclamk
left a comment
There was a problem hiding this comment.
Great work.
Thanks for extracting this from faster-pg-deletion.
src/os/bluestore/BlueStore.h
Outdated
| bool per_pool_omap = false; | ||
| enum { | ||
| // Please preserve the order since it's DB persistent | ||
| OMAP_UNSORTED = 0, |
Contributor
There was a problem hiding this comment.
How about changing "OMAP_UNSORTED" to "OMAP_BULK"?
It is just confusing because it is obviously sorted anyway.
src/common/options.cc
Outdated
|
|
||
| Option("bluestore_rocksdb_cfs", Option::TYPE_STR, Option::LEVEL_DEV) | ||
| .set_default("m(3) O(3,0-13) L") | ||
| .set_default("m(3) p(3) O(3,0-13) L") |
Contributor
There was a problem hiding this comment.
"p(3,0-12)" is better.
It will make hash calculation for column family sharding purposes to bytes 0-11.
I just assume that it is better to keep all omaps for one pg in single rocksdb column.
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
5cac644 to
f9c95fa
Compare
Contributor
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been split out of #37496 to speed up "ondisk format" modifications merge.
The primary goal for the changes is to provide bulk omap removal ability.
Additionally this PR depends (syntactically only) on Adam's #38499
Signed-off-by: Igor Fedotov ifedotov@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox