Skip to content

librbd: minor fix to IO shut-down and increased IO logging#38492

Merged
trociny merged 3 commits intoceph:masterfrom
dillaman:wip-librbd-io-tweaks
Dec 11, 2020
Merged

librbd: minor fix to IO shut-down and increased IO logging#38492
trociny merged 3 commits intoceph:masterfrom
dillaman:wip-librbd-io-tweaks

Conversation

@dillaman
Copy link

@dillaman dillaman commented Dec 8, 2020

Increased debug logging on the migration IO path for assisting with the "TestMigration.StressLive" failure. Also fixed a race condition that resulted in that test hanging but which doesn't need to be backported.

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

Jason Dillaman added 3 commits December 8, 2020 10:01
Allow actual IOs to be seen in the debug logs next to the client
debug logs issuing the IOs.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Otherwise, if the dispatchers are shut down, there is a potential
race where the flush can be assigned to a stuck IO and never
completed.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants