librados: add RadosClient to conf observers#38358
Merged
tchaikov merged 2 commits intoceph:masterfrom Dec 4, 2020
Merged
Conversation
Commit 306eebe added the RadosClient to the config observer interface but forgot to add it to the observer list. This meant that the RadosClient was never receiving callbacks to handle_conf_change. Commit a8a2374 exposed this issue because the mon timeout was configured at run-time. Fixes: https://tracker.ceph.com/issues/48030 Fixes: a8a2374 Fixes: 306eebe Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
adamemerson
approved these changes
Nov 30, 2020
The timeout was not initialized with the current config value during RadosClient construction. Fixes a8a2374 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
neha-ojha
approved these changes
Dec 2, 2020
Member
|
reproducer tests passed: https://pulpito.ceph.com/nojha-2020-12-01_15:33:51-rados:monthrash-wip-48030-2-distro-basic-smithi/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/48030
Fixes: a8a2374
Fixes: 306eebe
Signed-off-by: Patrick Donnelly pdonnell@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox