Skip to content

rgw/multisite: Add testcases for multisite sync policy#38238

Closed
soumyakoduri wants to merge 2 commits intoceph:mainfrom
soumyakoduri:bucket-sync-testcases2
Closed

rgw/multisite: Add testcases for multisite sync policy#38238
soumyakoduri wants to merge 2 commits intoceph:mainfrom
soumyakoduri:bucket-sync-testcases2

Conversation

@soumyakoduri
Copy link
Contributor

@soumyakoduri soumyakoduri commented Nov 23, 2020

Added few cases to test multisite sync policy configuration & its basic functionality -
https://docs.ceph.com/en/latest/radosgw/multisite-sync-policy/

This PR also includes the fix from Yehuda for the issue#https://tracker.ceph.com/issues/48416, needed for successful run of the tests.

Fixes: https://tracker.ceph.com/issues/48416
Fixes: https://tracker.ceph.com/issues/55812
Signed-off-by: Soumya Koduri skoduri@redhat.com

@mattbenjamin
Copy link
Contributor

@soumyakoduri can you report the issues you're currently seeing?

@soumyakoduri soumyakoduri force-pushed the bucket-sync-testcases2 branch 2 times, most recently from c15da58 to b242960 Compare November 25, 2020 08:45

return

def test_sync_pipe_multiple_buckets_to_single():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yehudasa ..I tested this (and the below test case - test_sync_pipe_single_bucket_to_multiple) configuration manually. It doesn't seem to be working. The data is not synced. Could you please take a look and let me know if I missed out anything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumyakoduri sure, I will take a look

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumyakoduri looking at it now, you should be creating different pipes to different source buckets. See here: yehudasa@40a7511

Also, it's better if you set a wildcard 'allowed' policy at the zonegroup level, and create the bucket sync policy on the bucket. So at the zonegroup level just specify '*' as source and dest buckets, and for this test create two separate pipes on the (preferably target) bucket policy itself. Bucket policy changes don't require period update, only ones that are on the zonegroup.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumyakoduri also see here for the second part: yehudasa@d993fa0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumyakoduri looking at it now, you should be creating different pipes to different source buckets. See here: yehudasa@40a7511

Also, it's better if you set a wildcard 'allowed' policy at the zonegroup level, and create the bucket sync policy on the bucket. So at the zonegroup level just specify '*' as source and dest buckets, and for this test create two separate pipes on the (preferably target) bucket policy itself. Bucket policy changes don't require period update, only ones that are on the zonegroup.

Thanks. That worked. So that means instead of creating comma separated bucket list, there should be different pipe created for each <source,dest> bucket combination.. right?

For the second part, I will add them as separate test-cases. Most of the test cases added here are to test functionality at zonegroup level, except for the last one. Will now create corresponding bucket-level cases for each of them.

@soumyakoduri soumyakoduri force-pushed the bucket-sync-testcases2 branch from 183f123 to 1ca0f84 Compare November 27, 2020 19:14
@soumyakoduri soumyakoduri force-pushed the bucket-sync-testcases2 branch from 1ca0f84 to b675f8f Compare December 5, 2020 05:33
@soumyakoduri soumyakoduri force-pushed the bucket-sync-testcases2 branch from b675f8f to 21c10f2 Compare December 6, 2020 09:42
@soumyakoduri soumyakoduri changed the title (WIP)rgw/multisite: Add testcases for multisite sync policy rgw/multisite: Add testcases for multisite sync policy Dec 6, 2020
@soumyakoduri soumyakoduri force-pushed the bucket-sync-testcases2 branch from 21c10f2 to f785a17 Compare December 16, 2020 19:28
@soumyakoduri
Copy link
Contributor Author

retest this please

@soumyakoduri soumyakoduri force-pushed the bucket-sync-testcases2 branch from f785a17 to fa79e35 Compare January 18, 2021 08:18
@stale
Copy link

stale bot commented Jul 21, 2021

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Jul 21, 2021
@soumyakoduri
Copy link
Contributor Author

unstale

@stale stale bot removed the stale label Jul 21, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Jan 9, 2022
@soumyakoduri
Copy link
Contributor Author

soumyakoduri commented Jun 21, 2022

@yehudasa @cbodley @smanjara .. the testcases have been updated to work on the latest 'main' branch. Below are the results of just sync-policy related tests added in this PR -

http://pulpito.front.sepia.ceph.com/soumyakoduri-2022-06-22_06:04:14-rgw:multisite-bucket-sync-testcases2-distro-default-smithi/

Kindly review the changes.

@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

yehudasa and others added 2 commits August 25, 2022 10:54
Fixes: https://tracker.ceph.com/issues/48416

bucket was passed in without bucket_id, now reading entrypoint
info if needed.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Added test cases for the various use-cases of multisite sync
policy feature listed in
https://docs.ceph.com/en/latest/radosgw/multisite-sync-policy/

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
@soumyakoduri
Copy link
Contributor Author

jenkins test make check

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

2 similar comments
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants